Uh oh!
There was an error while loading. Please reload this page.
[3.14] gh-119452: Remove select, skip 'truncated' test - #142178
Closed
encukou wants to merge 3 commits into
Closed
Conversation
This removes the select added in commit 29c657a. As Greg put it in https://github.com/python/cpython/pull/119455/files#r2580052775: > why select at all here given we just want to block on reading another chunk? > if the socket closes or errors, that'd return anyways. This makes the function wait forever for the query body. Thus, the new test 'test_large_content_length_truncated' times out. This was the case before the fix, too.
encukou
commented
Dec 2, 2025
MemberAuthor
#142180 instead uses |
serhiy-storchaka
commented
Dec 3, 2025
Member
Without timeout logic we cannot test that the fix actually works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the select added in commit 29c657a.
As Greg put it in https://github.com/python/cpython/pull/119455/files#r2580052775:
This makes the function wait forever for the query body. Thus, the new test 'test_large_content_length_truncated' times out. This was the case before the fix, too.