Skip to content

gh-124379: Document _PyStackRef - #142321

Merged
colesbury merged 3 commits into
python:mainfrom
colesbury:stackrefs-internal-docs
Dec 8, 2025
Merged

gh-124379: Document _PyStackRef#142321
colesbury merged 3 commits into
python:mainfrom
colesbury:stackrefs-internal-docs

Conversation

@colesbury

@colesburycolesbury commented Dec 5, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Dec 5, 2025
Closed
Fidget-Spinner
Fidget-Spinner approved these changes Dec 5, 2025
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Could you also please take a look at #141675 ? If that goes in, then some of the docs will go out of date as we won't be using different tagging schemes anymore.

mpage
mpage reviewed Dec 5, 2025
View reviewed changes

@mpagempage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions inline

Comment threadInternalDocs/stackrefs.md Outdated
Comment threadInternalDocs/stackrefs.md Outdated
Comment threadInternalDocs/stackrefs.md Outdated
kumaraditya303
kumaraditya303 reviewed Dec 6, 2025
View reviewed changes
Comment threadInternalDocs/stackrefs.md Outdated
colesburyand others added 2 commits December 8, 2025 09:49
@colesbury@kumaraditya303@mpage
Apply suggestions from code review
6b9eca9
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: mpage <mpage@cs.stanford.edu>
@colesbury
Suggestion from mpage
8e10812
@colesbury
colesbury merged commit f2fba4c into python:mainDec 8, 2025
83 of 85 checks passed
@colesbury
colesbury deleted the stackrefs-internal-docs branch December 8, 2025 17:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpagempagempage left review comments
@kumaraditya303kumaraditya303kumaraditya303 left review comments
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@markshannonmarkshannonAwaiting requested review from markshannon
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@colesbury@mpage@Fidget-Spinner@kumaraditya303