Uh oh!
There was an error while loading. Please reload this page.
gh-141658: JIT: lazy executor flush while the world is stopped - #142329
Closed
maurycy wants to merge 2 commits into
Closed
gh-141658: JIT: lazy executor flush while the world is stopped#142329maurycy wants to merge 2 commits into
maurycy wants to merge 2 commits into
Conversation
maurycy
requested review from
ZeroIntensity, ericsnowcurrently and markshannon
as code ownersDecember 6, 2025 00:22
maurycy
commented
Dec 6, 2025
ContributorAuthor
Fidget-Spinner
commented
Dec 6, 2025
Member
You could try reducing the capacity of the list and run it with instrumentation code to see if a deadlock happens? Otherwise this is very unlikely to happen, but it's still good we fix it. |
| return 0; | ||
| } | ||
| #endif | ||
| return 1; |
There was a problem hiding this comment.
Is this correct? It's still not safe even with the GIL.
| can_clear_executor_deletion_list(PyInterpreterState *interp) | ||
| { | ||
| #ifdef Py_GIL_DISABLED | ||
| if (_PyRuntime.stoptheworld.world_stopped || interp->stoptheworld.world_stopped) { |
There was a problem hiding this comment.
Do you need FT atomic reads here?
maurycy
marked this pull request as draft
December 8, 2025 14:25
maurycy
commented
Dec 19, 2025
ContributorAuthor
This is no longer needed, as per #142931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #141658 for more details.
The problem I'm having here is reproducing this reliably.