Skip to content

gh-134584: Remove custom float decref ops - #142576

Merged
Fidget-Spinner merged 10 commits into
python:mainfrom
Fidget-Spinner:decref_float_refactor
Dec 15, 2025
Merged

gh-134584: Remove custom float decref ops#142576
Fidget-Spinner merged 10 commits into
python:mainfrom
Fidget-Spinner:decref_float_refactor

Conversation

@Fidget-Spinner

@Fidget-SpinnerFidget-Spinner commented Dec 11, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Dec 11, 2025
Closed
35 tasks
markshannon
markshannon reviewed Dec 11, 2025
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the STACK_SIZE macro unchanged to avoid confusion and change https://github.com/python/cpython/pull/142576/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2L199
instead.

Comment threadPython/optimizer_analysis.c
markshannon
markshannon reviewed Dec 11, 2025
View reviewed changes
Comment threadPython/bytecodes.c
markshannon
markshannon approved these changes Dec 15, 2025
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks.

@markshannon

markshannon commented Dec 15, 2025

Copy link
Copy Markdown
Member

One thing to note for the future: We are losing the ability to reuse one of the operands if its refcount was one. A possible future optimization is to not only track which references are deferred, but which are the only reference to the object. We can then avoid the allocation & deallocation that occurs in a + b + c

@Fidget-Spinner
Fidget-Spinner merged commit 0ac4e6c into python:mainDec 15, 2025
76 checks passed
@Fidget-Spinner
Fidget-Spinner deleted the decref_float_refactor branch December 15, 2025 19:39
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@Fidget-Spinner@fatelei
pythongh-134584: Remove custom float decref ops (pythonGH-142576)
dc77837
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fidget-Spinner@markshannon