Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 35.2k
gh-142414: Remove singleton design pattern in Lib/concurrent/interpreters/_crossinterp.py.#142577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
d5060f7fb22cf67c3245f32617a05730fd5fcb33859a85aad4a7e0eeb6a206fb128769f74dcf9d08f96e2534bbfabb3dfeFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -427,6 +427,10 @@ def run(taskid, ready, blocker): | ||
| ready.get(timeout=1) # blocking | ||
| except interpreters.QueueEmpty: | ||
| pass | ||
| except queues.QueueEmpty: | ||
| # GH-142414: reloading the _queues module makes get to raise | ||
| # queues.QueueEmpty instead of interpreters.QueueEmpty. | ||
| pass | ||
Comment on lines
+430
to
+433
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like for this to be in a separate PR with a better test case.
| ||
| else: | ||
| done += 1 | ||
| pending -= done | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix spurious :exc:`KeyError` when :mod:`!concurrent.interpreters._queues` is reloaded after import. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.