gh-142651: Make call_count of Mock thread safe by chaope · Pull Request #142656 · python/cpython

chaope · 2025-12-13T06:15:13Z

gh-142651: Make call_count of Mock thread safe

bedevere-app · 2025-12-13T06:15:18Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…RtBu4.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…into fix-issue-142651

picnixz

LGTM.

miss-islington-app · 2025-12-15T11:43:19Z

Thanks @chaope for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

(cherry picked from commit 850f95f) Co-authored-by: chaope <pengchaoandy@gmail.com>

bedevere-app · 2025-12-15T11:43:41Z

GH-142743 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-12-15T11:43:47Z

GH-142744 is a backport of this pull request to the 3.13 branch.

…2743) gh-142651: make `Mock.call_count` thread-safe (GH-142656) (cherry picked from commit 850f95f) Co-authored-by: chaope <pengchaoandy@gmail.com>

…2744) gh-142651: make `Mock.call_count` thread-safe (GH-142656) (cherry picked from commit 850f95f) Co-authored-by: chaope <pengchaoandy@gmail.com>

bedevere-bot · 2025-12-15T12:58:04Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.14 (tier-2) has failed when building commit f172817.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1745/builds/910) and take a look at the build logs.
Check if the failure is related to this commit (f172817) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1745/builds/910

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 14, done. remote: Counting objects: 9% (1/11) remote: Counting objects: 18% (2/11) remote: Counting objects: 27% (3/11) remote: Counting objects: 36% (4/11) remote: Counting objects: 45% (5/11) remote: Counting objects: 54% (6/11) remote: Counting objects: 63% (7/11) remote: Counting objects: 72% (8/11) remote: Counting objects: 81% (9/11) remote: Counting objects: 90% (10/11) remote: Counting objects: 100% (11/11) remote: Counting objects: 100% (11/11), done. remote: Compressing objects: 50% (1/2) remote: Compressing objects: 100% (2/2) remote: Compressing objects: 100% (2/2), done. remote: Total 14 (delta 9), reused 9 (delta 9), pack-reused 3 (from 2) 
From https://github.com/python/cpython
* branch 3.14 -> FETCH_HEAD
Note: switching to 'f17281741c623eefe364ae4d7fd643c44bffe208'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at f17281741c6 [3.14] gh-142651: make `Mock.call_count` thread-safe (GH-142656) (#142743)
Switched to and reset branch '3.14'
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `wasi/` directory instead (i.e. `python Tools/wasm/wasi`)
configure: WARNING: no system libmpdec found; falling back to bundled libmpdec (deprecated and scheduled for removal in Python 3.16)
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `wasi/` directory instead (i.e. `python Tools/wasm/wasi`)
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `wasi/` directory instead (i.e. `python Tools/wasm/wasi`)
configure: WARNING: using cross tools not prefixed with host tripletconfigure: WARNING: no system libmpdec found; falling back to bundled libmpdec (deprecated and scheduled for removal in Python 3.16)
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `wasi/` directory instead (i.e. `python Tools/wasm/wasi`)
../../Modules/_hacl/Lib_Memzero0.c:66:6: warning: "Your platform does not support any safe implementation of memzero -- consider a pull request!" [-W#warnings]
66 | #warning "Your platform does not support any safe implementation of memzero -- consider a pull request!"
|^
1 warning generated.
../../Modules/expat/xmlparse.c:8509:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat]
8508 | " (+" EXPAT_FMT_PTRDIFF_T("6") " bytes %s|%u, xmlparse.c:%d) %*s\"",
|~~~~~~~~~~~~~~~~~~~~~~~~
8509 | bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",
|^~~~~~~~~
1 warning generated.
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]
130 | # define htole32(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here
43 | #define htole32(x) (uint32_t)(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]
131 | # define le32toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here
44 | #define le32toh(x) (uint32_t)(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]
132 | # define htobe32(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here
37 | #define htobe32(x) __bswap32(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]
138 | # define be32toh(x) (htobe32((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here
38 | #define be32toh(x) __bswap32(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]
140 | # define htole64(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here
45 | #define htole64(x) (uint64_t)(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]
141 | # define le64toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here
46 | #define le64toh(x) (uint64_t)(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]
142 | # define htobe64(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here
39 | #define htobe64(x) __bswap64(x)
|^
In file included from ../../Modules/md5module.c:37:
In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]
149 | # define be64toh(x) (htobe64((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here
40 | #define be64toh(x) __bswap64(x)
|^
8 warnings generated.
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]
130 | # define htole32(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here
43 | #define htole32(x) (uint32_t)(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]
131 | # define le32toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here
44 | #define le32toh(x) (uint32_t)(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]
132 | # define htobe32(x) In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]
130 | # define htole32(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here
43 | #define htole32(x) (uint32_t)(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]
131 | # define le32toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here
44 | #define le32toh(x) (uint32_t)(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]
132 | # define htobe32(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here
37 | #define htobe32(x) __bswap32(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]
138 | # define be32toh(x) (htobe32((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here
38 | #define be32toh(x) __bswap32(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]
140 | # define htole64(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here
45 | #define htole64(x) (uint64_t)(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]
141 | # define le64toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here
46 | #define le64toh(x) (uint64_t)(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]
142 | # define htobe64(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here
39 | #define htobe64(x) __bswap64(x)
|^
In file included from ../../Modules/sha2module.c:48:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]
149 | # define be64toh(x) (htobe64((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here
40 | #define be64toh(x) __bswap64(x)
|^
\
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here
37 | #define htobe32(x) __bswap32(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]
138 | # define be32toh(x) (htobe32((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here
38 | #define be32toh(x) __bswap32(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]
140 | # define htole64(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here
45 | #define htole64(x) (uint64_t)(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]
141 | # define le64toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here
46 | #define le64toh(x) (uint64_t)(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]
142 | # define htobe64(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here
39 | #define htobe64(x) __bswap64(x)
|^
In file included from ../../Modules/sha1module.c:38:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]
149 | # define be64toh(x) (htobe64((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here
40 | #define be64toh(x) __bswap64(x)
|^
8 warnings generated.
8 warnings generated.
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]
130 | # define htole32(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here
43 | #define htole32(x) (uint32_t)(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]
131 | # define le32toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here
44 | #define le32toh(x) (uint32_t)(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]
132 | # define htobe32(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here
37 | #define htobe32(x) __bswap32(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]
138 | # define be32toh(x) (htobe32((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here
38 | #define be32toh(x) __bswap32(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]
140 | # define htole64(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here
45 | #define htole64(x) (uint64_t)(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]
141 | # define le64toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here
46 | #define le64toh(x) (uint64_t)(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]
142 | # define htobe64(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here
39 | #define htobe64(x) __bswap64(x)
|^
In file included from ../../Modules/blake2module.c:136:
In file included from ../../Modules/_hacl/Hacl_Hash_Blake2b.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]
149 | # define be64toh(x) (htobe64((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here
40 | #define be64toh(x) __bswap64(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]
130 | # define htole32(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here
43 | #define htole32(x) (uint32_t)(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]
131 | # define le32toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here
44 | #define le32toh(x) (uint32_t)(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]
132 | # define htobe32(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here
37 | #define htobe32(x) __bswap32(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]
138 | # define be32toh(x) (htobe32((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here
38 | #define be32toh(x) __bswap32(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]
140 | # define htole64(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here
45 | #define htole64(x) (uint64_t)(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]
141 | # define le64toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here
46 | #define le64toh(x) (uint64_t)(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]
142 | # define htobe64(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here
39 | #define htobe64(x) __bswap64(x)
|^
In file included from ../../Modules/sha3module.c:59:
In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]
149 | # define be64toh(x) (htobe64((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here
40 | #define be64toh(x) __bswap64(x)
|^
8 warnings generated.
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]
130 | # define htole32(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here
43 | #define htole32(x) (uint32_t)(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]
131 | # define le32toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here
44 | #define le32toh(x) (uint32_t)(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]
132 | # define htobe32(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here
37 | #define htobe32(x) __bswap32(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]
138 | # define be32toh(x) (htobe32((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here
38 | #define be32toh(x) __bswap32(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]
140 | # define htole64(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here
45 | #define htole64(x) (uint64_t)(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]
141 | # define le64toh(x) (x)
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here
46 | #define le64toh(x) (uint64_t)(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]
142 | # define htobe64(x) \
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here
39 | #define htobe64(x) __bswap64(x)
|^
In file included from ../../Modules/hmacmodule.c:44:
In file included from ../../Modules/_hacl/Hacl_HMAC.h:35:
In file included from ../../Modules/_hacl/include/krml/internal/types.h:89:
../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]
149 | # define be64toh(x) (htobe64((x)))
|^
/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here
40 | #define be64toh(x) __bswap64(x)
|^
8 warnings generated.
8 warnings generated.
LLVM ERROR: IO failure on output stream: No space left on device
make: *** [Makefile:1136: libpython3.14d.a] Error 1
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.14.bcannon-wasi.wasi.debug/build/Tools/wasm/wasi.py", line 12, in <module>
runpy.run_path(pathlib.Path(__file__).parent /"wasi", run_name="__main__")
File "<frozen runpy>", line 304, in run_path
File "<frozen runpy>", line 88, in _run_code
File "/home/buildbot/buildarea/3.14.bcannon-wasi.wasi.debug/build/Tools/wasm/wasi/__main__.py", line 549, in <module>
main()
File "/home/buildbot/buildarea/3.14.bcannon-wasi.wasi.debug/build/Tools/wasm/wasi/__main__.py", line 545, in main
dispatch[context.subcommand](context)
File "/home/buildbot/buildarea/3.14.bcannon-wasi.wasi.debug/build/Tools/wasm/wasi/__main__.py", line 118, in wrapperreturn func(context, working_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.14.bcannon-wasi.wasi.debug/build/Tools/wasm/wasi/__main__.py", line 377, in make_wasi_python
call(
File "/home/buildbot/buildarea/3.14.bcannon-wasi.wasi.debug/build/Tools/wasm/wasi/__main__.py", line 152, in call
subprocess.check_call(command, **kwargs, stdout=stdout, stderr=stderr)
File "/home/buildbot/.local/lib/python3.12/subprocess.py", line 413, in check_callraise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '--jobs', '4', 'all']' returned non-zero exit status 2.
⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `wasi/` directory instead (i.e. `python Tools/wasm/wasi`)

bedevere-bot · 2025-12-15T13:02:14Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.13 (tier-2) has failed when building commit 8ebda57.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1502/builds/1785) and take a look at the build logs.
Check if the failure is related to this commit (8ebda57) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1502/builds/1785

Failed tests:

test_asyncgen
test_zipfile

Failed subtests:

test_write_filtered_python_package - test.test_zipfile.test_core.PyZipFileTests.test_write_filtered_python_package

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
File "/Lib/test/libregrtest/single.py", line 181, in _runtest_env_changed_exc
_load_run_test(result, runtests)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/single.py", line 128, in _load_run_test
test_mod = importlib.import_module(module_name)
File "/Lib/importlib/__init__.py", line 88, in import_modulereturn _bootstrap._gcd_import(name[level:], package, level)
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/Lib/test/test_asyncgen.py", line 11, in <module>
requires_working_socket(module=True)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/Lib/test/support/__init__.py", line 642, in requires_working_socketraise unittest.SkipTest(msg)
unittest.case.SkipTest: requires socket support
Traceback (most recent call last):
File "/Lib/test/test_zipfile/test_core.py", line 1483, in test_write_filtered_python_packagewith TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
~~~~~~~~~~~~~~~~~^^^^^^^^
File "/Lib/zipfile/__init__.py", line 1444, in __exit__self.close()
~~~~~~~~~~^^
File "/Lib/zipfile/__init__.py", line 2019, in closeself._write_end_record()
~~~~~~~~~~~~~~~~~~~~~~^^
File "/Lib/zipfile/__init__.py", line 2074, in _write_end_recordself.fp.write(centdir)
~~~~~~~~~~~~~^^^^^^^^^OSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/test/libregrtest/single.py", line 310, in run_single_test
_runtest(result, runtests)
~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/single.py", line 281, in _runtest
_runtest_env_changed_exc(result, runtests,
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
display_failure=not verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/single.py", line 189, in _runtest_env_changed_excprint(f"{test_name} skipped -- {exc}", flush=True)
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^OSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/test/test_zipfile/test_core.py", line 1488, in test_write_filtered_python_package
zipfp.writepy(packagedir)
~~~~~~~~~~~~~^^^^^^^^^^^^
File "/Lib/zipfile/__init__.py", line 2186, in writepy
fname, arcname =self._get_codename(path[0:-3],
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
basename)
^^^^^^^^^
File "/Lib/zipfile/__init__.py", line 2266, in _get_codenameif _compile(file_py):
~~~~~~~~^^^^^^^^^
File "/Lib/zipfile/__init__.py", line 2229, in _compile
py_compile.compile(file, doraise=True, optimize=optimize)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/py_compile.py", line 172, in compile
importlib._bootstrap_external._write_atomic(cfile, bytecode, mode)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap_external>", line 212, in _write_atomicOSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/test/test_zipfile/test_core.py", line 1483, in test_write_filtered_python_packagewith TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
~~~~~~~~~~~~~^^OSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/runpy.py", line 198, in _run_module_as_mainreturn _run_code(code, main_globals, None,
"__main__", mod_spec)
File "/Lib/runpy.py", line 88, in _run_codeexec(code, run_globals)
~~~~^^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/worker.py", line 123, in <module>
main()
~~~~^^
File "/Lib/test/libregrtest/worker.py", line 119, in main
worker_process(worker_json)
~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/Lib/test/libregrtest/worker.py", line 84, in worker_process
result = run_single_test(test_name, runtests)
File "/Lib/test/libregrtest/single.py", line 314, in run_single_testprint(f"test {test_name} crashed -- {msg}",
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^file=sys.stderr, flush=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^OSError: [Errno 51] No space left on device

chaope · 2025-12-15T13:11:46Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.13 (tier-2) has failed when building commit 8ebda57.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1502/builds/1785) and take a look at the build logs.
Check if the failure is related to this commit (8ebda57) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1502/builds/1785

Failed tests:

test_asyncgen
test_zipfile

Failed subtests:

test_write_filtered_python_package - test.test_zipfile.test_core.PyZipFileTests.test_write_filtered_python_package

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
File "/Lib/test/libregrtest/single.py", line 181, in _runtest_env_changed_exc
_load_run_test(result, runtests)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/single.py", line 128, in _load_run_test
test_mod = importlib.import_module(module_name)
File "/Lib/importlib/__init__.py", line 88, in import_modulereturn _bootstrap._gcd_import(name[level:], package, level)
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/Lib/test/test_asyncgen.py", line 11, in <module>
requires_working_socket(module=True)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/Lib/test/support/__init__.py", line 642, in requires_working_socketraise unittest.SkipTest(msg)
unittest.case.SkipTest: requires socket support
Traceback (most recent call last):
File "/Lib/test/test_zipfile/test_core.py", line 1483, in test_write_filtered_python_packagewith TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
~~~~~~~~~~~~~~~~~^^^^^^^^
File "/Lib/zipfile/__init__.py", line 1444, in __exit__self.close()
~~~~~~~~~~^^
File "/Lib/zipfile/__init__.py", line 2019, in closeself._write_end_record()
~~~~~~~~~~~~~~~~~~~~~~^^
File "/Lib/zipfile/__init__.py", line 2074, in _write_end_recordself.fp.write(centdir)
~~~~~~~~~~~~~^^^^^^^^^OSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/test/libregrtest/single.py", line 310, in run_single_test
_runtest(result, runtests)
~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/single.py", line 281, in _runtest
_runtest_env_changed_exc(result, runtests,
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
display_failure=not verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/single.py", line 189, in _runtest_env_changed_excprint(f"{test_name} skipped -- {exc}", flush=True)
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^OSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/test/test_zipfile/test_core.py", line 1488, in test_write_filtered_python_package
zipfp.writepy(packagedir)
~~~~~~~~~~~~~^^^^^^^^^^^^
File "/Lib/zipfile/__init__.py", line 2186, in writepy
fname, arcname =self._get_codename(path[0:-3],
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
basename)
^^^^^^^^^
File "/Lib/zipfile/__init__.py", line 2266, in _get_codenameif _compile(file_py):
~~~~~~~~^^^^^^^^^
File "/Lib/zipfile/__init__.py", line 2229, in _compile
py_compile.compile(file, doraise=True, optimize=optimize)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/py_compile.py", line 172, in compile
importlib._bootstrap_external._write_atomic(cfile, bytecode, mode)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap_external>", line 212, in _write_atomicOSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/test/test_zipfile/test_core.py", line 1483, in test_write_filtered_python_packagewith TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
~~~~~~~~~~~~~^^OSError: [Errno 51] No space left on device
Traceback (most recent call last):
File "/Lib/runpy.py", line 198, in _run_module_as_mainreturn _run_code(code, main_globals, None,
"__main__", mod_spec)
File "/Lib/runpy.py", line 88, in _run_codeexec(code, run_globals)
~~~~^^^^^^^^^^^^^^^^^^^
File "/Lib/test/libregrtest/worker.py", line 123, in <module>
main()
~~~~^^
File "/Lib/test/libregrtest/worker.py", line 119, in main
worker_process(worker_json)
~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/Lib/test/libregrtest/worker.py", line 84, in worker_process
result = run_single_test(test_name, runtests)
File "/Lib/test/libregrtest/single.py", line 314, in run_single_testprint(f"test {test_name} crashed -- {msg}",
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^file=sys.stderr, flush=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^OSError: [Errno 51] No space left on device

Looks like we need to do cleanup or request more space in test run? Need to check the CICD pipeline to see what's best action here.

OSError: [Errno 51] No space left on device

colesbury · 2025-12-17T22:30:01Z

I've reopened the issue. This is still not thread-safe

Make call_count of Mock thread safe
a401818

chaope requested a review from cjw296 as a code owner December 13, 2025 06:15

bedevere-appBot added the awaiting review label Dec 13, 2025

bedevere-appBot mentioned this pull request Dec 13, 2025
ThreadingMock.call_count is not thread safe #142651
Closed

blurb-itBotand others added 3 commits December 13, 2025 06:17

📜🤖 Added by blurb_it.
d532d23

update doc
fe7be86

calculate call_count after append call_args_list
29578a9

picnixz reviewed Dec 13, 2025
View reviewed changes

Comment threadLib/unittest/mock.py
Comment threadDoc/library/unittest.mock.rst Outdated

cjw296 reviewed Dec 13, 2025
View reviewed changes

Comment threadDoc/library/unittest.mock.rst Outdated
Comment threadLib/test/test_unittest/testmock/testthreadingmock.py Outdated

chaope added 3 commits December 13, 2025 08:34

revert change on documentation for call_count.
c2e4ca7

revert unnecessary change.
e9e6dfa

revert blank line deletion
3a4b590

picnixz reviewed Dec 13, 2025
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2025-12-13-06-17-44.gh-issue-142651.ZRtBu4.rst Outdated
Comment threadLib/test/test_unittest/testmock/testthreadingmock.py Outdated

chaopeand others added 9 commits December 13, 2025 09:20

added TestThreadingMockRaceCondition
70e9107

Update Misc/NEWS.d/next/Library/2025-12-13-06-17-44.gh-issue-142651.Z…
dc0d804
…RtBu4.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_unittest/testmock/testthreadingmock.py
f05407e
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

update test
3a81b0d

Merge branch 'fix-issue-142651' ofhttps://github.com/chaope/cpython…
23825f4
…into fix-issue-142651

move self._executor.shutdown to addCleanup
a76318e

use 3k loops
8e2348c

add @requires_resource('cpu')
e7dcc57

update test according to comments
851f698

picnixz reviewed Dec 13, 2025
View reviewed changes

Comment threadLib/test/test_unittest/testmock/testthreadingmock.py Outdated
Comment threadLib/test/test_unittest/testmock/testthreadingmock.py

update according to comments
3b29867

picnixz approved these changes Dec 13, 2025
View reviewed changes

Comment threadLib/test/test_unittest/testmock/testthreadingmock.py

bedevere-appBot added awaiting merge and removed awaiting review labels Dec 13, 2025

picnixz requested a review from cjw296 December 13, 2025 21:30

kumaraditya303 reviewed Dec 14, 2025
View reviewed changes

Comment threadLib/test/test_unittest/testmock/testthreadingmock.py

use threading_helper.start_threads
16232b8

kumaraditya303 approved these changes Dec 14, 2025
View reviewed changes

kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 14, 2025

kumaraditya303 merged commit 850f95f into python:mainDec 15, 2025
50 checks passed

bedevere-appBot removed the awaiting merge label Dec 15, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 15, 2025
pythongh-142651: makeMock.call_countthread-safe (pythonGH-142656)
3ae84a0
(cherry picked from commit 850f95f) Co-authored-by: chaope <pengchaoandy@gmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 15, 2025
pythongh-142651: makeMock.call_countthread-safe (pythonGH-142656)
f551c5b
(cherry picked from commit 850f95f) Co-authored-by: chaope <pengchaoandy@gmail.com>

bedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Dec 15, 2025

bedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Dec 15, 2025

chaope deleted the fix-issue-142651 branch December 15, 2025 12:29

fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
pythongh-142651: makeMock.call_countthread-safe (python#142656)
e63c16b

Uh oh!

Uh oh!

Conversation

chaope commented Dec 13, 2025

Uh oh!

bedevere-appBot commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-appBot commented Dec 15, 2025

Uh oh!

bedevere-appBot commented Dec 15, 2025

Uh oh!

bedevere-appBot commented Dec 15, 2025

Uh oh!

bedevere-bot commented Dec 15, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 15, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

chaope commented Dec 15, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

colesbury commented Dec 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

colesbury commented Dec 17, 2025•
edited
Loading