Skip to content

gh-138122: Add some screenshots to the profiling.sampling docs - #142676

Merged
pablogsal merged 8 commits into
python:mainfrom
pablogsal:tachyon-images
Dec 14, 2025
Merged

gh-138122: Add some screenshots to the profiling.sampling docs#142676
pablogsal merged 8 commits into
python:mainfrom
pablogsal:tachyon-images

Conversation

@pablogsal

@pablogsalpablogsal commented Dec 13, 2025•
edited by hugovk
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Dec 13, 2025
Open
StanFromIreland
StanFromIreland reviewed Dec 13, 2025
View reviewed changes

@StanFromIrelandStanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts:

  • To start, great idea :-)
  • Maybe put the images in a folder for organisation?
  • Did you optimise the pngs? (For one way to do this see, #139061)
  • What do you think about adding an example tachyon-flamegraph.html to _static?

Comment threadDoc/library/tachyon-pstats.png
@pablogsal

pablogsal commented Dec 13, 2025

Copy link
Copy Markdown
MemberAuthor

All done

@pablogsal
pablogsalforce-pushed the tachyon-images branch 3 times, most recently from dd0eb7b to d5a75fbCompareDecember 13, 2025 19:31
StanFromIreland
StanFromIreland reviewed Dec 13, 2025
View reviewed changes
Comment threadDoc/_static/tachyon-example-flamegraph.html
@hugovkhugovk mentioned this pull request Dec 13, 2025
Merged
@hugovk

hugovk commented Dec 13, 2025

Copy link
Copy Markdown
Member

To fix EPUB: pablogsal#116

@pablogsal

pablogsal commented Dec 14, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks a lot @hugovk

StanFromIreland
StanFromIreland reviewed Dec 14, 2025
View reviewed changes
Comment threadDoc/library/profiling.sampling.rst Outdated
Comment threadDoc/library/profiling.sampling.rst Outdated
Comment threadDoc/library/profiling.sampling.rst Outdated
Comment threadDoc/library/profiling.sampling.rst Outdated
Comment threadDoc/library/profiling.sampling.rst Outdated
Comment threadDoc/library/profiling.sampling.rst Outdated
pablogsaland others added 2 commits December 14, 2025 15:33
@pablogsal@StanFromIreland
Apply suggestions from code review
4384211
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@pablogsal@StanFromIreland
Apply suggestion from@StanFromIreland
dc7c409
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland
StanFromIreland approved these changes Dec 14, 2025
View reviewed changes

@StanFromIrelandStanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
pablogsal merged commit e4d3c83 into python:mainDec 14, 2025
46 checks passed
@pablogsal
pablogsal deleted the tachyon-images branch December 14, 2025 17:43
@pablogsal

pablogsal commented Dec 14, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for the review everyone!

fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@pablogsal@hugovk
@StanFromIreland@fatelei
pythongh-138122: Add some screenshots to the profiling.sampling docs (p…
5da657a
…ython#142676)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@m-aciekm-aciek mentioned this pull request Mar 4, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@hugovk@StanFromIreland