Skip to content

gh-134584: Eliminate redundant refcounting from _CALL_LIST_APPEND - #142711

Merged
Fidget-Spinner merged 4 commits into
python:mainfrom
Zheaoli:manjusaka/134584-list-append
Dec 15, 2025
Merged

gh-134584: Eliminate redundant refcounting from _CALL_LIST_APPEND#142711
Fidget-Spinner merged 4 commits into
python:mainfrom
Zheaoli:manjusaka/134584-list-append

Conversation

@Zheaoli

@ZheaoliZheaoli commented Dec 14, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Dec 14, 2025
Closed
35 tasks
Fidget-Spinner
Fidget-Spinner reviewed Dec 14, 2025
View reviewed changes
Comment threadPython/bytecodes.c Outdated
Comment threadLib/test/test_capi/test_opt.py Outdated
Fidget-Spinner
Fidget-Spinner reviewed Dec 14, 2025
View reviewed changes
Comment threadPython/bytecodes.c Outdated
Zheaoliand others added 2 commits December 14, 2025 23:08
@Zheaoli@Fidget-Spinner
Update Python/bytecodes.c
420510b
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
@Zheaoli
fix review idea
3b02881
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
3578c70
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli

Zheaoli commented Dec 14, 2025

Copy link
Copy Markdown
ContributorAuthor

@Fidget-Spinner Ops, I forget the optimizer_bytecodes.c path, naive mistake. Fixed. PTAL when you got time

Fidget-Spinner
Fidget-Spinner approved these changes Dec 14, 2025
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I will leave it for one day and merge tomorrow.

@Fidget-Spinner
Fidget-Spinner merged commit 872ab51 into python:mainDec 15, 2025
74 checks passed
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@Zheaoli@Fidget-Spinner@fatelei
pythongh-134584: Eliminate redundant refcounting from _CALL_LIST_APPE…
9d42a14
…ND (pythonGH-142711)
Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
@tonghuaroottonghuaroot mentioned this pull request Jun 25, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zheaoli@Fidget-Spinner