Skip to content

gh-141070: Rename PyUnstable_Object_Dump to PyObject_Dump - #142848

Merged
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:rename-pyobject-dump
Jan 16, 2026
Merged

gh-141070: Rename PyUnstable_Object_Dump to PyObject_Dump#142848
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:rename-pyobject-dump

Conversation

@ZeroIntensity

@ZeroIntensityZeroIntensity commented Dec 16, 2025

Copy link
Copy Markdown
Member

See the DPO thread. As a result of my grumpiness (sorry!), the consensus seems to be that it's fine to keep this in the public API, primarily to save typing time when debugging.


📚 Documentation preview 📚: https://cpython-previews--142848.org.readthedocs.build/

@ZeroIntensity

Copy link
Copy Markdown
MemberAuthor

Victor and Petr: It wasn't clear to me whether this needed a new C API WG issue -- if you'd like another vote, please let me know.

@encukou

Copy link
Copy Markdown
Member

I reopened capi-workgroup/decisions#87 (comment).

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The C API Working Group approved renaming the function to PyObject_Dump(): capi-workgroup/decisions#87 (comment)

@ZeroIntensity
ZeroIntensity merged commit 19e64af into python:mainJan 16, 2026
50 checks passed
@ZeroIntensity
ZeroIntensity deleted the rename-pyobject-dump branch January 16, 2026 14:19
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x (tier-1) has failed when building commit 19e64af.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/146/builds/12997) and take a look at the build logs.
  4. Check if the failure is related to this commit (19e64af) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/146/builds/12997

Failed tests:

  • test_venv

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_venv.py", line 90, in tearDown
rmtree(self.env_dir)
~~~~~~^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 497, in rmtree
_rmtree(path)
~~~~~~~^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 440, in _rmtree
_waitfor(_rmtree_inner, path, waitall=True)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 381, in _waitfor
func(pathname)
~~~~^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 436, in _rmtree_inner
_waitfor(_rmtree_inner, fullname, waitall=True)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 381, in _waitfor
func(pathname)
~~~~^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 439, in _rmtree_inner
_force_run(fullname, os.unlink, fullname)
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 222, in _force_runreturn func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_u5ltfkb0\\tmpkw5w_0ai\\Scripts\\python_d.exe'
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 524, in temp_dir
os.mkdir(path)
~~~~~~~~^^^^^^FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_1080æ'
Stack (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 196, in _run_module_as_mainreturn _run_code(code, main_globals, None,
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 87, in _run_codeexec(code, run_globals)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 138, in <module>
main()
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 133, in mainwith os_helper.temp_cwd(work_dir, quiet=True):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 141, in __enter__returnnext(self.gen)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 597, in temp_cwdwith temp_dir(path=name, quiet=quiet) as temp_path:
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 211, in _force_runreturn func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_u5ltfkb0\\tmpkw5w_0ai\\Scripts\\python_d.exe'
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 211, in _force_runreturn func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_o1j8g22c\\tmp0khjj9r6\\Scripts\\python_d.exe'
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 524, in temp_dir
os.mkdir(path)
~~~~~~~~^^^^^^FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_1892æ'
Stack (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 196, in _run_module_as_mainreturn _run_code(code, main_globals, None,
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 87, in _run_codeexec(code, run_globals)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 138, in <module>
main()
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 133, in mainwith os_helper.temp_cwd(work_dir, quiet=True):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 141, in __enter__returnnext(self.gen)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 597, in temp_cwdwith temp_dir(path=name, quiet=quiet) as temp_path:
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_venv.py", line 90, in tearDown
rmtree(self.env_dir)
~~~~~~^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 497, in rmtree
_rmtree(path)
~~~~~~~^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 440, in _rmtree
_waitfor(_rmtree_inner, path, waitall=True)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 381, in _waitfor
func(pathname)
~~~~^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 436, in _rmtree_inner
_waitfor(_rmtree_inner, fullname, waitall=True)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 381, in _waitfor
func(pathname)
~~~~^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 439, in _rmtree_inner
_force_run(fullname, os.unlink, fullname)
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 222, in _force_runreturn func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_o1j8g22c\\tmp0khjj9r6\\Scripts\\python_d.exe'

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ZeroIntensity@encukou@bedevere-bot@vstinner