Uh oh!
There was an error while loading. Please reload this page.
gh-142681: Preserve Lib/test/data/NormalizationTest-3.2.0.txt in make distclean - #142943
Closed
warsaw wants to merge 1 commit into
Closed
gh-142681: Preserve Lib/test/data/NormalizationTest-3.2.0.txt in make distclean#142943warsaw wants to merge 1 commit into
make distclean#142943warsaw wants to merge 1 commit into
Conversation
warsaw
requested review from
AA-Turner, emmatyping and erlend-aasland
as code ownersDecember 18, 2025 16:33
serhiy-storchaka
commented
Dec 18, 2025
Member
It was already fixed in #142935, wasn't it? |
encukou
commented
Dec 18, 2025
Member
I merged #142935 just before I saw this PR, sorry :/ I think it's better to move the file. If we were to add an exception, we'd also want a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to
Makefile.pre.inso thatmake distcleandoesn't leave you with a dirty repo. Needs backport to 3.14 and 3.13.