Skip to content

gh-122581: Use parser mutex in default build for subinterpreters - #142959

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-122581-parser-stats
Dec 20, 2025
Merged

gh-122581: Use parser mutex in default build for subinterpreters#142959
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-122581-parser-stats

Conversation

@colesbury

@colesburycolesbury commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

The data race also affected subinterpreters in the default build.

@colesbury

Copy link
Copy Markdown
ContributorAuthor

This was caught by running ./python -m test test_datetime -m test_concurrent_initialization_subinterpreter -v with TSan, but that test still can't be enabled because there are other unfixed data races.

@ZeroIntensity

Copy link
Copy Markdown
Member

Ouch, I wrote that test as part of #136583. What other races are you seeing?

@colesbury

Copy link
Copy Markdown
ContributorAuthor

@ZeroIntensity - Mostly things from #129824

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much else to discuss here, LGTM.

@colesbury
colesbury merged commit 2b4feee into python:mainDec 20, 2025
54 checks passed
@colesbury
colesbury deleted the gh-122581-parser-stats branch December 20, 2025 20:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@ZeroIntensity