Skip to content

gh-140648: Make asyncio REPL respect the -I flag (isolated mode) - #143045

Merged
kumaraditya303 merged 7 commits into
python:mainfrom
johnslavik:asyncio-repl-respect-isolated-mode
Jan 3, 2026
Merged

gh-140648: Make asyncio REPL respect the -I flag (isolated mode)#143045
kumaraditya303 merged 7 commits into
python:mainfrom
johnslavik:asyncio-repl-respect-isolated-mode

Conversation

@johnslavik

@johnslavikjohnslavik commented Dec 21, 2025

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Dec 21, 2025
`os.linesep` was incorrect.
The writer already normalizes line ending at the lower level.
+We can reuse `spawn_asyncio_repl`.
@johnslavik

This comment was marked as resolved.

@johnslavik

This comment was marked as resolved.

@ZeroIntensityZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed tests Tests in the Lib/test dir labels Dec 21, 2025
Comment threadLib/test/test_repl.py
@kumaraditya303
kumaraditya303 merged commit e7c542d into python:mainJan 3, 2026
58 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @johnslavik for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2026
…de) (pythonGH-143045)
(cherry picked from commit e7c542d)
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app

Copy link
Copy Markdown

GH-143383 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jan 3, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2026
…de) (pythonGH-143045)
(cherry picked from commit e7c542d)
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app

Copy link
Copy Markdown

GH-143384 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jan 3, 2026
kumaraditya303 pushed a commit that referenced this pull request Jan 3, 2026
…ode) (GH-143045) (#143384)
gh-140648: Make asyncio REPL respect the `-I` flag (isolated mode) (GH-143045)
(cherry picked from commit e7c542d)
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
kumaraditya303 pushed a commit that referenced this pull request Jan 3, 2026
…ode) (GH-143045) (#143383)
gh-140648: Make asyncio REPL respect the `-I` flag (isolated mode) (GH-143045)
(cherry picked from commit e7c542d)
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit dced1a7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1918) and take a look at the build logs.
  4. Check if the failure is related to this commit (dced1a7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1918

Failed tests:

  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1493, in test_repr_rlockself.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@johnslavik
johnslavik deleted the asyncio-repl-respect-isolated-mode branch July 21, 2026 01:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@johnslavik@bedevere-bot@kumaraditya303@ZeroIntensity