Uh oh!
There was an error while loading. Please reload this page.
gh-138122: Extend binary profiling format with full source location and opcode - #143088
Merged
Conversation
MemberAuthor
@lkollar smaller PR here to add opcode and location support to the file format. Most of the bulk is tests + docs update. |
…tion and opcode Add end_lineno, column, end_column, and opcode fields to frame entries. Uses delta encoding for end positions to minimize file size. reader, writer, tests, and documentation.
pablogsalforce-pushed
the
tachyon-binary-file-refux
branch
from
December 23, 2025 01:42
97a86dd to
bb4129fCompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
lkollar
reviewed
Dec 24, 2025
lkollar
left a comment
Contributor
There was a problem hiding this comment.
This looks great, just a couple of minor things.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pablogsal
commented
Dec 24, 2025
MemberAuthor
@lkollar fixed |
lkollar
approved these changes
Dec 24, 2025
| f"Thread ({interp_id}, {thread_id}), sample {i}, " | ||
| f"frame {j}: opcode mismatch " | ||
| f"(expected {exp_frame['opcode']}, got {act_frame['opcode']})", | ||
| ) |
There was a problem hiding this comment.
This is a long and duplicate list, that's not very dry, I wrote pablogsal#119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end_lineno, column, end_column, and opcode fields to frame entries.
Uses delta encoding for end positions to minimize file size.
reader, writer, tests, and documentation.