Skip to content

gh-138122: Remove default duration for statistical profiling - #143174

Merged
pablogsal merged 5 commits into
python:mainfrom
lkollar:profiling/no-default-duration
Dec 25, 2025
Merged

gh-138122: Remove default duration for statistical profiling#143174
pablogsal merged 5 commits into
python:mainfrom
lkollar:profiling/no-default-duration

Conversation

@lkollar

@lkollarlkollar commented Dec 25, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Instead of limiting profiling to 10s, let the process finish by default.

Towards #142927

@lkollar
Remove default duration
a27bd2e
Instead of limiting profiling to 10s, let the process finish by default.
@bedevere-appbedevere-appBot mentioned this pull request Dec 25, 2025
Open
@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

I think we still need to update the docs

@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

I think sample.py still has references to duration_sec=10

@pablogsal

pablogsal commented Dec 25, 2025

Copy link
Copy Markdown
Member

Pushed a small fix with the items left and a (somehow related) bug I found while testing

@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 18:24
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 18:24
@picnixzpicnixz changed the title gh-138122: Remove default durationgh-138122: Remove default duration for statistical profilingDec 25, 2025
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 18:46
@pablogsal
pablogsal enabled auto-merge (squash) December 25, 2025 19:12
@pablogsal
pablogsal merged commit 888d101 into python:mainDec 25, 2025
46 checks passed
@lkollar
lkollar deleted the profiling/no-default-duration branch December 25, 2025 20:06
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@lkollar@pablogsal@thunder-coding
pythongh-138122: Remove default duration for statistical profiling (p…
a989d45
…ython#143174)
Co-authored-by: Pablo Galindo Salgado <pablogsal@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lkollar@pablogsal