Skip to content

gh-143394: On macOS, run main PyREPL tests as "Apple Terminal" as well - #143461

Merged
ambv merged 1 commit into
python:mainfrom
ambv:gh-143394-followup
Jan 6, 2026
Merged

gh-143394: On macOS, run main PyREPL tests as "Apple Terminal" as well#143461
ambv merged 1 commit into
python:mainfrom
ambv:gh-143394-followup

Conversation

@ambv

@ambvambv commented Jan 5, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This would have prevented the issue introduced in gh-138732 by catching the missing safe escape code:

Screenshot 2026-01-05 at 23 23 04

@bedevere-appbedevere-appBot added awaiting core review tests Tests in the Lib/test dir labels Jan 5, 2026
@bedevere-appbedevere-appBot mentioned this pull request Jan 5, 2026
Closed
@ambvambv added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 5, 2026
@ambv
ambv merged commit 7dae107 into python:mainJan 6, 2026
54 checks passed
@miss-islington-app

miss-islington-appBot commented Jan 6, 2026

Copy link
Copy Markdown

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2026
@ambv@miss-islington
pythongh-143394: On macOS, run main PyREPL tests as "Apple Terminal" …
08dd6db
…as well (pythonGH-143461)
(cherry picked from commit 7dae107)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2026
@ambv@miss-islington
pythongh-143394: On macOS, run main PyREPL tests as "Apple Terminal" …
7bb1d9e
…as well (pythonGH-143461)
(cherry picked from commit 7dae107)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app

bedevere-appBot commented Jan 6, 2026

Copy link
Copy Markdown

GH-143466 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jan 6, 2026
@bedevere-app

bedevere-appBot commented Jan 6, 2026

Copy link
Copy Markdown

GH-143467 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jan 6, 2026
@chris-eiblchris-eibl mentioned this pull request Jan 6, 2026
Merged
ambv added a commit that referenced this pull request Jan 6, 2026
@miss-islington@ambv
[3.14]gh-143394: On macOS, run main PyREPL tests as "Apple Terminal"…
7d52ea8
… as well (GH-143461) (GH-143466)
(cherry picked from commit 7dae107)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jan 6, 2026
@miss-islington@ambv
[3.13]gh-143394: On macOS, run main PyREPL tests as "Apple Terminal"…
2cd3b0e
… as well (GH-143461) (GH-143467)
(cherry picked from commit 7dae107)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@ambv@thunder-coding
pythongh-143394: On macOS, run main PyREPL tests as "Apple Terminal" …
5b411bf
…as well (pythonGH-143461)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ambv@JulioDEV-S