Uh oh!
There was an error while loading. Please reload this page.
gh-143811: Add helpful default error messages to AttributeError and NameError - #143813
Closed
johnslavik wants to merge 3 commits into
Closed
gh-143811: Add helpful default error messages to AttributeError and NameError#143813johnslavik wants to merge 3 commits into
AttributeError and NameError#143813johnslavik wants to merge 3 commits into
Conversation
johnslavik
commented
Jan 13, 2026
Comment on lines
1140
to
1141
| wrong_name = getattr(exc_value, "name", None) | ||
| if wrong_name is not None and wrong_name in sys.stdlib_module_names: |
MemberAuthor
There was a problem hiding this comment.
Out of scope, within the same function: wrong_name = ... and wrong_name is not None and could be removed here.
MemberAuthor
There was a problem hiding this comment.
@serhiy-storchaka, what do you think? Would it be of benefit to change it in this PR?
I've already made one unrelated change to reduce redundancy (although necessary to keep things simple).
johnslavik
commented
Jan 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
a12k
reviewed
Jan 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Aaron Wieczorek <aaronw@fastmail.com>
johnslavik
commented
Apr 1, 2026
MemberAuthor
I'm not confident in this change, but I'll revisit the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttributeErrorin__getattr__shows a garbled message with attribute suggestions #143811CC @a12k for review