Skip to content

gh-106318: Improve str.rstrip() method doc - #143893

Merged
vstinner merged 7 commits into
python:mainfrom
adorilson:106318.rstrip
Feb 11, 2026
Merged

gh-106318: Improve str.rstrip() method doc#143893
vstinner merged 7 commits into
python:mainfrom
adorilson:106318.rstrip

Conversation

@adorilson

@adorilsonadorilson commented Jan 15, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

WIP to #106318

#106318: Improve str.rstrip() method doc

📚 Documentation preview 📚: https://cpython-previews--143893.org.readthedocs.build/

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels Jan 15, 2026
@bedevere-appbedevere-appBot mentioned this pull request Jan 15, 2026
Open
vstinner
vstinner reviewed Jan 19, 2026
View reviewed changes
Comment threadDoc/library/stdtypes.rst Outdated
@adorilson@vstinner
Update Doc/library/stdtypes.rst
eb31bd6
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Jan 19, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nedbat
nedbat reviewed Feb 10, 2026
View reviewed changes
Comment threadDoc/library/stdtypes.rst Outdated

See :meth:`str.removesuffix` for a method that will remove a single suffix
string rather than all of a set of characters. For example::
See also :meth:`strip` and :meth:`removesuffix`.

@nedbatnedbatFeb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the original for these lines.

  • it is eye-catching and surprising
  • It shows the two methods side-by-side.
  • it honors our forebearers.

@vstinnervstinnerFeb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I like these 'Monty Python' examples, I would also prefer to keep them.

@adorilsonadorilsonFeb 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. With other improvements.

@vstinner
vstinner merged commit 936d60d into python:mainFeb 11, 2026
29 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsFeb 11, 2026
@vstinner

vstinner commented Feb 11, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

@vstinnervstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 11, 2026
@miss-islington-app

miss-islington-appBot commented Feb 11, 2026

Copy link
Copy Markdown

Thanks @adorilson for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Feb 11, 2026

Copy link
Copy Markdown

Thanks @adorilson for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2026
@adorilson@vstinner
@StanFromIreland@miss-islington
pythongh-106318: Improve str.rstrip() method doc (pythonGH-143893)
2ac34f1
(cherry picked from commit 936d60d)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2026
@adorilson@vstinner
@StanFromIreland@miss-islington
pythongh-106318: Improve str.rstrip() method doc (pythonGH-143893)
dd2ee87
(cherry picked from commit 936d60d)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Feb 11, 2026

Copy link
Copy Markdown

GH-144698 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Feb 11, 2026
@bedevere-app

bedevere-appBot commented Feb 11, 2026

Copy link
Copy Markdown

GH-144699 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Feb 11, 2026
@vstinner

vstinner commented Feb 11, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

vstinner added a commit that referenced this pull request Feb 11, 2026
@miss-islington@adorilson
@vstinner@StanFromIreland
[3.14]gh-106318: Improve str.rstrip() method doc (GH-143893) (#144699)
a77dde4
gh-106318: Improve str.rstrip() method doc (GH-143893)
(cherry picked from commit 936d60d)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner added a commit that referenced this pull request Feb 11, 2026
@miss-islington@adorilson
@vstinner@StanFromIreland
[3.13]gh-106318: Improve str.rstrip() method doc (GH-143893) (#144698)
a5b1952
gh-106318: Improve str.rstrip() method doc (GH-143893)
(cherry picked from commit 936d60d)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@adorilson@vstinner
@StanFromIreland@thunder-coding
pythongh-106318: Improve str.rstrip() method doc (python#143893)
9dc4914
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@adorilson@vstinner
@StanFromIreland@brijkapadia
pythongh-106318: Improve str.rstrip() method doc (python#143893)
f67040f
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@adorilson@vstinner
@StanFromIreland@ljfp
pythongh-106318: Improve str.rstrip() method doc (python#143893)
0ec54d2
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedbatnedbatnedbat approved these changes
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adorilson@vstinner@nedbat@StanFromIreland