Skip to content

[3.12] gh-144125: email: verify headers are sound in BytesGenerator - #144188

Merged
sethmlarson merged 2 commits into
python:3.12from
miss-islington:backport-052e55e-3.12
Feb 13, 2026
Merged

[3.12] gh-144125: email: verify headers are sound in BytesGenerator#144188
sethmlarson merged 2 commits into
python:3.12from
miss-islington:backport-052e55e-3.12

Conversation

@miss-islington

@miss-islingtonmiss-islington commented Jan 23, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 052e55e)

Co-authored-by: Seth Michael Larson seth@python.org
Co-authored-by: Denis Ledoux dle@odoo.com
Co-authored-by: Denis Ledoux 5822488+beledouxdenis@users.noreply.github.com
Co-authored-by: Petr Viktorin 302922+encukou@users.noreply.github.com
Co-authored-by: Bas Bloemsaat 1586868+basbloemsaat@users.noreply.github.com

@sethmlarson@beledouxdenis
@encukou@basbloemsaat@miss-islington
pythongh-144125: email: verify headers are sound in BytesGenerator
8df6632
(cherry picked from commit 052e55e)
Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Denis Ledoux <dle@odoo.com>
Co-authored-by: Denis Ledoux <5822488+beledouxdenis@users.noreply.github.com>
Co-authored-by: Petr Viktorin <302922+encukou@users.noreply.github.com>
Co-authored-by: Bas Bloemsaat <1586868+basbloemsaat@users.noreply.github.com>
@miss-islington
miss-islington requested a review from a team as a code ownerJanuary 23, 2026 17:08
@bedevere-appbedevere-appBot mentioned this pull request Jan 23, 2026
Closed
pablogsal
pablogsal reviewed Jan 25, 2026
View reviewed changes

@pablogsalpablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou

encukou commented Jan 26, 2026

Copy link
Copy Markdown
Member

@webknjaz Hmm. Is this failure familiar?
The UI doesn't show any info:

image

But the downloadable logs contain:

Job is waiting for a hosted runner to come online.
2026-01-26T17:03:37.2490000Z Evaluating build-windows.if
2026-01-26T17:03:37.2490000Z Evaluating: (success() && (fromJSON(needs.build-context.outputs.run-windows-tests)))
2026-01-26T17:03:37.2490000Z Expanded: (true && true)
2026-01-26T17:03:37.2490000Z Result: true
2026-01-26T17:03:37.2490000Z Evaluating build-windows.arm64_false.build.if
2026-01-26T17:03:37.2490000Z Evaluating: success()
2026-01-26T17:03:37.2490000Z Result: true
2026-01-26T17:03:38.9380000Z Requested labels: windows-2022
2026-01-26T17:03:38.9380000Z Job defined at: python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge
2026-01-26T17:03:38.9380000Z Reusable workflow chain:
2026-01-26T17:03:38.9380000Z python/cpython/.github/workflows/build.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)
2026-01-26T17:03:38.9380000Z -> python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)
2026-01-26T17:03:38.9380000Z Waiting for a runner to pick up this job...
2026-01-26T17:03:39.8610000Z Job is about to start running on the hosted runner: GitHub Actions 1000510261
2026-01-26T17:03:39.8610000Z Job is waiting for a hosted runner to come online.

2026-01-26T17:03:43.2883707Z ##[error]Could not find a part of the path 'D:\a'.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

@encukou not sure but sound like a problem with their runners. I've restarted them in debug mode to see if that exposes anything else.

The cancellation behavior is rather weird — sounds like something in the jobs failed, then GHA went ahead to cancel them citing those same jobs as the reason for cancellation. Usually, jobs in matrices are marked as failed when they fail and if there's fail-fast, other jobs are marked as cancelled. Maybe, normal failed state cleanup timed out and GHA was cancelling those as well. But this is just a speculation..

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Oh.. I didn't notice this is an old branch. It's probably a good idea to diff the CI infra with main. This is one of the reasons I insist on backporting all the CI changes into all the branches.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

So merging #144036 30 minutes ago failed. It's the last commit on the branch. Yesterday, everything was fine, though (when Pablo merged the target branch into that PR). So this is new.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Looking at https://github.com/actions/runner-images?tab=readme-ov-file#available-images, the last windows-2022 runner rebuild was on Jan 19, it seems.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Trying to restart jobs one at a time with debugging on.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Looks like Win32 is the problem.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Weird.. I've seen each of those jobs crashing flakily. But mostly when they ran in parallel. Now that I've restarted each individually, they seem to be running fine. Definitely a platform problem...

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

@encukou it's probably a good idea to complain to GH support unless it self-heals.

I've downloaded the logs from https://github.com/python/cpython/actions/runs/21365488062/job/61510137519 (DEBUG RUN!)

And they've got something similar:

$ cat 1_Windows\ _\ build\ and\ test\ \(Win32\).txt2026-01-26T18:39:28.6558234Z ##[debug]Starting: Windows / build and test (Win32)2026-01-26T18:39:28.6630888Z ##[error]Could not find a part of the path 'D:\a'.2026-01-26T18:39:28.6637136Z ##[debug]System.IO.DirectoryNotFoundException: Could not find a part of the path 'D:\a'.2026-01-26T18:39:28.6638073Z ##[debug] at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor)2026-01-26T18:39:28.6638844Z ##[debug] at System.IO.Directory.CreateDirectory(String path)2026-01-26T18:39:28.6639798Z ##[debug] at GitHub.Runner.Worker.JobRunner.RunAsync(AgentJobRequestMessage message, CancellationToken jobRequestCancellationToken)2026-01-26T18:39:28.6655833Z ##[debug]Finishing: Windows / build and test (Win32)
$ cat Windows\ _\ build\ and\ test\ \(Win32\)/system.txt2026-01-26T18:39:25.2470000Z Requested labels: windows-20222026-01-26T18:39:25.2470000Z Job defined at: python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge2026-01-26T18:39:25.2470000Z Reusable workflow chain:2026-01-26T18:39:25.2470000Z python/cpython/.github/workflows/build.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)2026-01-26T18:39:25.2470000Z -> python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)2026-01-26T18:39:25.2470000Z Waiting for a runner to pick up this job...2026-01-26T18:39:25.2450000Z Evaluating build-windows.if2026-01-26T18:39:25.2450000Z Evaluating: (success() && (fromJSON(needs.build-context.outputs.run-windows-tests)))2026-01-26T18:39:25.2450000Z Expanded: (true && true)2026-01-26T18:39:25.2450000Z Result: true2026-01-26T18:39:25.2450000Z Evaluating build-windows.Win32_false.build.if2026-01-26T18:39:25.2450000Z Evaluating: success()2026-01-26T18:39:25.2450000Z Result: true2026-01-26T18:39:25.7450000Z Job is waiting for a hosted runner to come online.2026-01-26T18:39:25.7450000Z Job is about to start running on the hosted runner: GitHub Actions 1000510807

This one has a trace in debug ^

The runner diagnostic logs don't have anything interesting and also seem to only have the alls-green job details with Ubuntu paths inside and nothing about Windows.

Attaching the logs for history: logs_55453059899.zip.

@encukou

encukou commented Jan 27, 2026

Copy link
Copy Markdown
Member

Thanks for the investigation!

it's probably a good idea to complain to GH support unless it self-heals.

I'll keep an eye out for this happening again.

@webknjaz

webknjaz commented Jan 27, 2026

Copy link
Copy Markdown
Member

So merging #144036 30 minutes ago failed. It's the last commit on the branch. Yesterday, everything was fine, though (when Pablo merged the target branch into that PR). So this is new.

I've just restarted the failing jobs on that commit and it they didn't crash immediately: https://github.com/python/cpython/actions/runs/21366922074. So I think it's safe to say the flaky behavior is gone for now.

@webknjazwebknjaz moved this from 🚧 In progress 🚧 to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫Jan 27, 2026
@kbrezina

kbrezina commented Feb 9, 2026

Copy link
Copy Markdown

Hey guys,
I wonder whether I can expect 3.12.13 anytime soon? I suppose these changes are required for it.
Thanks for info.

@sethmlarson

sethmlarson commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Going to merge this one since @pablogsal left a LGTM above. Thanks everyone for the investigation.

@sethmlarson
sethmlarson merged commit e417f05 into python:3.12Feb 13, 2026
186 of 217 checks passed
@miss-islington
miss-islington deleted the backport-052e55e-3.12 branch February 13, 2026 16:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal left review comments
@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees

No one assigned

Labels

release-blockertype-securityA security issue

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington@encukou@webknjaz@kbrezina@sethmlarson@pablogsal