Skip to content

gh-140550: allow slots that repeat information from PyModuleDef - #144340

Merged
encukou merged 4 commits into
python:mainfrom
encukou:slotparrot
Feb 9, 2026
Merged

gh-140550: allow slots that repeat information from PyModuleDef#144340
encukou merged 4 commits into
python:mainfrom
encukou:slotparrot

Conversation

@encukou

@encukouencukou commented Jan 30, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

From feedback on the discussion thread:

When integrating slots-based module creation is with the inittab, which currently requires PyModuleDef, it would be convenient to reuse the the same slots array for the MethodDef.

This PR allows slots that match what's already present in the PyModuleDef.

cc @ngoldbaum

📚 Documentation preview 📚: https://cpython-previews--144340.org.readthedocs.build/

@encukou
pythongh-140550: allow slots that repeat information from PyModuleDef
48ab83f
When integrating slots-based module creation is with the inittab,
which currently requires PyModuleDef, it would be convenient to
reuse the the same slots array for the MethodDef.
Allow slots that match what's already present in the PyModuleDef.
@bedevere-appbedevere-appBot mentioned this pull request Jan 30, 2026
Open
25 tasks
@encukou
encukou marked this pull request as draft January 30, 2026 12:55
@ngoldbaum

ngoldbaum commented Jan 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

I can confirm that with this PR the PyO3 tests all pass on my for-petr branch, which uses the same slots array for both initialization hooks and unconditionally sets m_name and m_doc in PyModuleDef. It's fine for PyO3's purposes to have duplicate information with this check to make sure that the duplicate information matches exactly.

@ngoldbaumngoldbaum mentioned this pull request Jan 30, 2026
Merged
@encukou
encukou marked this pull request as ready for review January 30, 2026 15:23
encukou
encukou commented Jan 30, 2026
View reviewed changes
Comment threadDoc/c-api/module.rst Outdated
encukou
encukou commented Jan 30, 2026
View reviewed changes
Comment threadObjects/moduleobject.c Outdated
vstinner
vstinner reviewed Feb 3, 2026
View reviewed changes
Comment threadDoc/c-api/module.rst
@ngoldbaum

ngoldbaum commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Hi all - it'd be nice to have this merged by next week so this can be in 3.15a6 due out on Feb 10th. It'd be nice to not have the workaround for the old behavior committed to PyO3, see PyO3/pyo3#5753 (comment).

@encukou
encukou merged commit b22ff1e into python:mainFeb 9, 2026
47 checks passed
@encukou
encukou deleted the slotparrot branch February 9, 2026 10:35
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@encukou@thunder-coding
pythongh-140550: allow slots that repeat information from PyModuleDef (…
3931535
…pythonGH-144340)
When integrating slots-based module creation is with the inittab,
which currently requires PyModuleDef, it would be convenient to
reuse the the same slots array for the MethodDef.
Allow slots that match what's already present in the PyModuleDef.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@encukou@ljfp
pythongh-140550: allow slots that repeat information from PyModuleDef (…
4c9469d
…pythonGH-144340)
When integrating slots-based module creation is with the inittab,
which currently requires PyModuleDef, it would be convenient to
reuse the the same slots array for the MethodDef.
Allow slots that match what's already present in the PyModuleDef.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@ngoldbaum@vstinner