Skip to content

gh-123471: Make concurrent iteration over itertools.permutations and itertools.combinations_with_replacement thread-safe - #144402

Merged
colesbury merged 8 commits into
python:mainfrom
eendebakpt:cwr_ft
Feb 4, 2026
Merged

gh-123471: Make concurrent iteration over itertools.permutations and itertools.combinations_with_replacement thread-safe#144402
colesbury merged 8 commits into
python:mainfrom
eendebakpt:cwr_ft

Conversation

@eendebakpt

@eendebakpteendebakpt commented Feb 2, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Feb 2, 2026
Open
colesbury
colesbury reviewed Feb 2, 2026
View reviewed changes
Comment threadLib/test/test_free_threading/test_itertools.py Outdated
colesbury
colesbury reviewed Feb 2, 2026
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. I left a comment about the test above.

Would you please also add a news entry?

eendebakpt
eendebakpt commented Feb 3, 2026
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2026-02-03-08-50-58.gh-issue-123471.yF1Gym.rst Outdated
kumaraditya303
kumaraditya303 approved these changes Feb 4, 2026
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

colesbury
colesbury approved these changes Feb 4, 2026
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@colesbury
colesbury merged commit 009c8c0 into python:mainFeb 4, 2026
51 checks passed
@miss-islington-app

miss-islington-appBot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks @eendebakpt for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Feb 4, 2026

Copy link
Copy Markdown

Sorry, @eendebakpt and @colesbury, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 009c8c052f5eb9f869c09029724ef194d8c161ca 3.14

@colesbury

colesbury commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Hmmm... are we backporting these sorts of PRs to 3.14 or no? It looks like some of the other ones are 3.15 only.

encukou pushed a commit to encukou/cpython that referenced this pull request Feb 5, 2026
@eendebakpt@encukou
pythongh-123471: Make concurrent iteration over `itertools.permutatio…
ca530a4
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
@eendebakpteendebakpt mentioned this pull request Feb 5, 2026
Closed
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@eendebakpt@thunder-coding
pythongh-123471: Make concurrent iteration over `itertools.permutatio…
f97b13e
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@eendebakpt@ljfp
pythongh-123471: Make concurrent iteration over `itertools.permutatio…
4c870ad
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
@StanFromIreland

StanFromIreland commented May 2, 2026

Copy link
Copy Markdown
Member

Hmmm... are we backporting these sorts of PRs to 3.14 or no? It looks like some of the other ones are 3.15 only.

Can we remove the backport label?

@naschemenascheme mentioned this pull request Jul 14, 2026
Closed
@serhiy-storchaka

serhiy-storchaka commented Jul 15, 2026

Copy link
Copy Markdown
Member

Please don't forget about backports.

nascheme added a commit that referenced this pull request Jul 17, 2026
@nascheme@eendebakpt@kumaraditya303
[3.14]gh-123471: Free-threading fixes for itertools (GH-131212) (GH-…
45bfb43
…132814) (GH-135689) (GH-144402) (GH-146033) (GH-142957) (GH-153791)
Combined backport of PRs from main branch, fixing free-threading data-races in itertools:
* gh-123471: make concurrent iteration over `itertools.cycle` safe under free-threading (gh-131212)
* gh-123471: Make itertools.product and itertools.combinations thread-safe (GH-132814)
* gh-123471: Make itertools.chain thread-safe (gh-135689)
* gh-123471: Make concurrent iteration over `itertools.permutations` and `itertools.combinations_with_replacement` thread-safe (gh-144402)
* gh-123471: make concurrent iteration over itertools.accumulate thread-safe (gh-144486)
* gh-123471: Make `itertools.zip_longest` safe in the FT build (gh-146033)
(cherry picked from commit 26a1cd4)
(cherry picked from commit 847d1c2)
(cherry picked from commit 0533c1f)
(cherry picked from commit 009c8c0)
(cherry picked from commit 3a24856)
(cherry picked from commit 9214e3f)
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@StanFromIrelandStanFromIreland removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees

@colesburycolesbury

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eendebakpt@colesbury@StanFromIreland@serhiy-storchaka@kumaraditya303@jalaheshammohamed-sketch