Skip to content

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions - #144669

Closed
vstinner wants to merge 2 commits into
python:3.14from
vstinner:windows_2025
Closed

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions#144669
vstinner wants to merge 2 commits into
python:3.14from
vstinner:windows_2025

Conversation

@vstinner

@vstinnervstinner commented Feb 10, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Replace windows-2022 with windows-2025.

@vstinner
pythongh-138744: Upgrade Windows to 2025 in GitHub Actions
9d53eaa
Replace windows-2022 with windows-2025.
@bedevere-appbedevere-appBot mentioned this pull request Feb 10, 2026
Closed
@vstinner

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

I skipped test_dtrace on Windows in the 3.14 branch: #144657. So tests should pass again on Windows 2025.

@vstinner

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

cc @Fidget-Spinner

StanFromIreland
StanFromIreland reviewed Feb 10, 2026
View reviewed changes
Comment thread.github/workflows/tail-call.yml
@vstinner
vstinner marked this pull request as draft February 10, 2026 14:50
@vstinner

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

The Windows CI was skipped since my PR only modify files of the .github/ directory. I mark my PR as a draft and modify a random file (Lib/test/test_dtrace.py) to trigger the Windows CI.

@vstinner

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

All Windows CIs passed. Examples:

JIT / i686-pc-windows-msvc/msvc (Debug) (pull_request)
JIT / i686-pc-windows-msvc/msvc (Release) (pull_request)
JIT / x86_64-pc-windows-msvc/msvc (Debug) (pull_request)
JIT / x86_64-pc-windows-msvc/msvc (Release) (pull_request)
Tail calling interpreter / x86_64-pc-windows-msvc/msvc (pull_request)
Tests / Windows (free-threading) / Build and test (arm64) (pull_request)
Tests / Windows (free-threading) / Build and test (x64) (pull_request)
Tests / Windows / Build and test (arm64) (pull_request)
Tests / Windows / Build and test (Win32) (pull_request)
Tests / Windows / Build and test (x64) (pull_request)
Tests / Windows MSI / installer for arm64 (pull_request)
Tests / Windows MSI / installer for x64 (pull_request)
Tests / Windows MSI / installer for x86 (pull_request)

hugovk
hugovk reviewed Feb 10, 2026
View reviewed changes
Comment thread.github/workflows/tail-call.yml
Comment thread.github/workflows/reusable-windows-msi.yml
build:
name: installer for ${{ inputs.arch }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}

@hugovkhugovkFeb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make this change in main?

Comment thread.github/workflows/reusable-windows.yml
build:
name: Build and test (${{ inputs.arch }})
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}

@hugovkhugovkFeb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this in main?

Comment thread.github/workflows/jit.yml
- target: i686-pc-windows-msvc/msvc
architecture: Win32
runner: windows-2022
runner: windows-2025

@hugovkhugovkFeb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this in main?

Comment thread.github/workflows/jit.yml
- target: x86_64-pc-windows-msvc/msvc
architecture: x64
runner: windows-2022
runner: windows-2025

@hugovkhugovkFeb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

@vstinner

vstinner commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

Oh, I misunderstood the commit 25e99b3. I expected that it already upgraded Windows to 2025 for all CI jobs, but in fact it only changes "Windows tailcall CI".

I closed this PR to redo the change in the main branch first: #144682.

@vstinner
vstinner deleted the windows_2025 branch July 10, 2026 20:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments
@hugovkhugovkhugovk left review comments
@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@webknjazwebknjazwebknjaz approved these changes
@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@ambv@webknjaz@hugovk@StanFromIreland