Skip to content

gh-66305: Fix a hang on Windows in the tempfile module - #144672

Merged
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:tempfile-hangs-on-bad-tempdir
Feb 24, 2026
Merged

gh-66305: Fix a hang on Windows in the tempfile module#144672
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:tempfile-hangs-on-bad-tempdir

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Feb 10, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

It occurred when trying to create a temporary file or subdirectory in a non-writable directory.

@serhiy-storchaka
pythongh-66305: Fix a hang for a few seconds on Windows in the tempfi…
5753c73
…le module
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
@serhiy-storchaka
serhiy-storchaka requested a review from a teamFebruary 10, 2026 14:58
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 10, 2026
@bedevere-appbedevere-appBot mentioned this pull request Feb 10, 2026
Closed
@serhiy-storchaka

serhiy-storchaka commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

Reducing the number of attempts should help, but I have not tested yet.

@serhiy-storchaka
serhiy-storchakaforce-pushed the tempfile-hangs-on-bad-tempdir branch from 77ade1f to ac17d9eCompareFebruary 10, 2026 19:26
@serhiy-storchakaserhiy-storchaka changed the title gh-66305: Fix a hang for a few seconds on Windows in the tempfile modulegh-66305: Fix a hang on Windows in the tempfile moduleFeb 10, 2026
@serhiy-storchaka

serhiy-storchaka commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

Tested on Windows. There was a test for readonly tempdir, but it was always skipped on Windows. It was not for a few seconds, but for about 10 days (for estimations). Now the test correctly works on Windows.

@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review February 10, 2026 19:43
@serhiy-storchaka
serhiy-storchaka merged commit ca66d3c into python:mainFeb 24, 2026
47 checks passed
@miss-islington-app

miss-islington-appBot commented Feb 24, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the tempfile-hangs-on-bad-tempdir branch February 24, 2026 11:05
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2026
@serhiy-storchaka@miss-islington
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
9644041
…H-144672)
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2026
@serhiy-storchaka@miss-islington
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
115c28f
…H-144672)
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-appBot commented Feb 24, 2026

Copy link
Copy Markdown

GH-145168 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Feb 24, 2026
@bedevere-app

bedevere-appBot commented Feb 24, 2026

Copy link
Copy Markdown

GH-145169 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Feb 24, 2026
serhiy-storchaka added a commit that referenced this pull request Feb 24, 2026
@miss-islington@serhiy-storchaka
[3.14]gh-66305: Fix a hang on Windows in the tempfile module (GH-144672
da03b36
) (GH-145168)
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Feb 24, 2026
@miss-islington@serhiy-storchaka
[3.13]gh-66305: Fix a hang on Windows in the tempfile module (GH-144672
cb1d20b
) (GH-145169)
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
(cherry picked from commit ca66d3c)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@serhiy-storchaka@brijkapadia
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
79b918d
…H-144672)
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka@ljfp
pythongh-66305: Fix a hang on Windows in the tempfile module (pythonG…
90976f2
…H-144672)
It occurred when trying to create a temporary file or subdirectory in
a non-writable directory.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadAwaiting requested review from gpshead
@zoobazoobaAwaiting requested review from zooba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@serhiy-storchaka