Uh oh!
There was an error while loading. Please reload this page.
Datetime: Tidy up docs - #144720
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
There was a problem hiding this comment.
The diagram in pathlib is useful as the inheritance is non-standard. I don't think that's the case here, perhaps the only such instance is date <- datetime. What's the justification for adding it?
There was a problem hiding this comment.
What's the justification for adding it?
The diagram is already in the documentation, albeit in textual form.
AA-Turner
commented
Feb 12, 2026
feedback: this PR could have been more usefully structured as an optional set of style guide changes, addition of markup, and adding an image; to allow discussing each on its own merits. Probably not worth doing now that this has been opened, but please keep in mind for the future. A |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
StanFromIreland
commented
Feb 12, 2026
Thanks Hugo! |
Uh oh!
There was an error while loading. Please reload this page.
Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, @StanFromIreland and @encukou, I could not cleanly backport this to |
(cherry picked from commit c6a142f) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-144956 is a backport of this pull request to the 3.14 branch. |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Fix some style guide infringements (case of titles, Latin abbreviations), add parameter mark up in a few places, fix a small typo, make spacing of docs consistent, and add an inheritance diagram (like pathlib's :-).
Diagram
Generated with graphviz, and:
📚 Documentation preview 📚: https://cpython-previews--144720.org.readthedocs.build/en/144720/library/datetime.html