gh-142349: Clarify lazy import filters have positional-only parameters by johnslavik · Pull Request #144856 · python/cpython

johnslavik · 2026-02-15T23:55:02Z

Failing example:

importsyssys.set_lazy_imports_filter(lambda*, importing_module, imported_module, fromlist: True)
lazyimportfoobar

Issue: Implement PEP 810 – Explicit lazy imports #142349

📚 Documentation preview 📚: https://cpython-previews--144856.org.readthedocs.build/

bedevere-app · 2026-02-15T23:57:46Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

johnslavik · 2026-02-16T00:07:19Z

I have made the requested changes; please review again

bedevere-app · 2026-02-16T00:07:25Z

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

johnslavik · 2026-02-21T00:11:03Z

@AA-Turner :-)

johnslavik · 2026-03-20T08:08:30Z

@AA-Turner

johnslavik · 2026-04-15T01:11:02Z

@AA-Turner (If you can't look into this I'll appreciate if you just tell! Thanks!)

github-actions · 2026-05-17T12:18:28Z

This PR is stale because it has been open for 30 days with no activity.

johnslavik · 2026-05-17T13:24:19Z

@AA-Turner

johnslavik · 2026-06-05T17:32:30Z

@AA-Turner :-)

johnslavik · 2026-07-24T18:59:56Z

I'm requesting a review from @encukou as Adam is unavailable.

read-the-docs-community · 2026-07-24T19:02:41Z

Documentation build overview

📚 cpython-previews | 🛠️ Build #33779896 | 📁 Comparing 9a2a9f4 against main (46acb79)

🔍 Preview build

7 files changed · ± 7 modified

±Modified

encukou

Asking for review is asking for nitpicks, right?

Please click "update branch" or do git merge main (depending on your workflow) to get the tools the current CI needs.

Co-authored-by: Petr Viktorin <encukou@gmail.com>

…onal

johnslavik · 2026-07-25T07:58:06Z

Thank you so much for providing the suggestions!

johnslavik · 2026-07-25T11:34:58Z

Changed the targeted issue to match.

Requested changes were made.

miss-islington-app · 2026-07-28T09:14:55Z

Thanks @johnslavik for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app · 2026-07-28T09:15:08Z

GH-154808 is a backport of this pull request to the 3.15 branch.

…rameters (GH-144856) (GH-154808) (cherry picked from commit 66eb823) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

Clarify lazy import filters have positional-only arguments
f869e9c

johnslavik added the skip news label Feb 15, 2026

bedevere-appBot added the awaiting review label Feb 15, 2026

bedevere-appBot mentioned this pull request Feb 15, 2026
Update function signatures to use * and / as needed #131885
Open
5 tasks

bedevere-appBot added the docs Documentation in the Doc dir label Feb 15, 2026

github-project-automationBot added this to Docs PRs Feb 15, 2026

johnslavik changed the title ~~gh-131885: Clarify lazy import filters have positional-only arguments~~gh-131885: Clarify lazy import filters have positional-only parametersFeb 15, 2026

github-project-automationBot moved this to Todo in Docs PRs Feb 15, 2026

johnslavik requested a review from AA-Turner February 15, 2026 23:56

AA-Turner previously requested changes Feb 15, 2026
View reviewed changes

Comment threadDoc/library/sys.rst Outdated

bedevere-appBot added awaiting changes and removed awaiting review labels Feb 15, 2026

Don't describe arguments as positional in written sentences
4eebd62

bedevere-appBot added awaiting change review and removed awaiting changes labels Feb 16, 2026

bedevere-appBot requested a review from AA-Turner February 16, 2026 00:07

Yhg1s added the topic-lazy-imports label Mar 17, 2026

github-actionsBot added the stale Stale PR or inactive for long period of time. label May 17, 2026

github-actionsBot removed the stale Stale PR or inactive for long period of time. label May 26, 2026

johnslavik added 2 commits July 24, 2026 20:57

Make the docs more correct
d4c5563

Remove the trailing /
ca4de39

johnslavik requested a review from encukou July 24, 2026 18:59

encukou reviewed Jul 24, 2026
View reviewed changes

Comment threadDoc/library/sys.rst Outdated
Comment threadDoc/library/sys.rst Outdated

johnslavikand others added 2 commits July 25, 2026 09:45

Apply suggestions from code review
ec8e313
Co-authored-by: Petr Viktorin <encukou@gmail.com>

Merge branch 'main' into lazy-imports-filter-clarify-signature-positi…
d2d90b4
…onal

johnslavik requested a review from encukou July 25, 2026 07:57

johnslavik changed the title ~~gh-131885: Clarify lazy import filters have positional-only parameters~~gh-142349: Clarify lazy import filters have positional-only parametersJul 25, 2026

bedevere-appBot mentioned this pull request Jul 25, 2026
Implement PEP 810 – Explicit lazy imports #142349
Open

encukou reviewed Jul 27, 2026
View reviewed changes

Comment threadDoc/library/sys.rst Outdated

Remove redundant paragraph
9a2a9f4

bedevere-appBot added awaiting review and removed awaiting change review labels Jul 27, 2026

encukou merged commit 66eb823 into python:mainJul 28, 2026
58 of 65 checks passed

bedevere-appBot removed the awaiting review label Jul 28, 2026

github-project-automationBot moved this from Todo to Done in Docs PRs Jul 28, 2026

bedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 28, 2026

encukou pushed a commit that referenced this pull request Jul 28, 2026
[3.15]gh-142349: Clarify lazy import filters have positional-only pa…
3e670c3
…rameters (GH-144856) (GH-154808) (cherry picked from commit 66eb823) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

Uh oh!

Uh oh!

Conversation

johnslavik commented Feb 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-appBot commented Feb 15, 2026

Uh oh!

johnslavik commented Feb 16, 2026

Uh oh!

bedevere-appBot commented Feb 16, 2026

Uh oh!

johnslavik commented Feb 21, 2026

Uh oh!

johnslavik commented Mar 20, 2026

Uh oh!

johnslavik commented Apr 15, 2026

Uh oh!

github-actionsBot commented May 17, 2026

Uh oh!

johnslavik commented May 17, 2026

Uh oh!

johnslavik commented Jun 5, 2026

Uh oh!

johnslavik commented Jul 24, 2026

Uh oh!

read-the-docs-communityBot commented Jul 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

johnslavik commented Jul 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnslavik commented Jul 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-appBot commented Jul 28, 2026

Uh oh!

bedevere-appBot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

johnslavik commented Feb 15, 2026•
edited
Loading

read-the-docs-communityBot commented Jul 24, 2026•
edited
Loading

johnslavik commented Jul 25, 2026•
edited
Loading

johnslavik commented Jul 25, 2026•
edited
Loading