Uh oh!
There was an error while loading. Please reload this page.
gh-141510: Replace MappingProxyType with frozendict - #144904
Conversation
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Feb 17, 2026
Oh, the "Run mypy on Lib/tomllib" job fails with "Name frozendict is not defined" because it runs on an older Python version which doesn't have this new built-in type: |
vstinner
commented
Feb 17, 2026
I reverted the tomllib change to workaround the mypy issue. |
bitdancer
left a comment
There was a problem hiding this comment.
Approving the email change only, I'm not familiar with the other code bases.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Feb 18, 2026
cc @picnixz |
benediktjohannes
commented
Feb 18, 2026
Oh, tests are failing 0:13:17 load avg: 10.90 [1/1/1] test_dataclasses failed (1 failure) FAIL: test_field_repr (test.test_dataclasses.TestCase.test_field_repr)Traceback (most recent call last): |
benediktjohannes
commented
Feb 18, 2026
I'll have a look on this as soon as I've got some time |
vstinner
commented
Feb 18, 2026
I updated my branch and I updated test_dataclasses for
I updated |
benediktjohannes
commented
Feb 18, 2026
LGTM |
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Feb 18, 2026
Merged. Thanks for reviews. |
Uh oh!
There was an error while loading. Please reload this page.