Skip to content

gh-141510: Implement copy and deepcopy for frozendict - #144905

Merged
vstinner merged 9 commits into
python:mainfrom
eendebakpt:copy_module_frozendict
Feb 18, 2026
Merged

gh-141510: Implement copy and deepcopy for frozendict#144905
vstinner merged 9 commits into
python:mainfrom
eendebakpt:copy_module_frozendict

Conversation

@eendebakpt

@eendebakpteendebakpt commented Feb 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Feb 17, 2026
Closed
@eendebakpteendebakpt changed the title gh-41510: Implement copy and deepcopy for frozendictgh-141510: Implement copy and deepcopy for frozendictFeb 17, 2026
@bedevere-appbedevere-appBot mentioned this pull request Feb 17, 2026
Closed
@eendebakpt
eendebakpt marked this pull request as draft February 17, 2026 11:37
vstinner
vstinner reviewed Feb 17, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it a draft PR?

Changes cherry-picked from #141508 by @vstinner

I'm surprised that you created a PR from my WIP work. I'm currently splitting this big PR into smaller pieces, as I wrote in the PR.

Comment threadLib/test/test_copy.py Outdated
@eendebakpt

eendebakpt commented Feb 17, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Draft because there are failing tests are due to making _deepcopy_dispatch immutable. The failing test is a bit strange, see

cpython/Lib/test/test_descr.py

Line 318 in 6ef2578

# This is an ugly hack:

I will look into this.

@eendebakpt

eendebakpt commented Feb 17, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm surprised that you created a PR from my WIP work. I'm currently splitting this big PR into smaller pieces, as I wrote in the PR.

Sorry, my mistake. Feel free to close the PR if it is interfering.

vstinner
vstinner reviewed Feb 17, 2026
View reviewed changes
Comment threadLib/copy.py Outdated
return type(x)(x.__func__, deepcopy(x.__self__, memo))
d[types.MethodType] = _deepcopy_method

_deepcopy_dispatch = frozendict(d)

@vstinnervstinnerFeb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not convert it to a frozendict in this PR, since it's not directly related to supporting frozendict in copy: remove this line and revert test_descr changes.

@eendebakpteendebakptFeb 17, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it here. Do you want me to open a separate PR for this part?

@vstinnervstinnerFeb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote #144909 to use frozendict in multiple stdlib modules. I will to see how this PR goes before proposing changing copy._deepcopy_dispatch to frozendict.

eendebakpt
eendebakpt commented Feb 17, 2026
View reviewed changes
Comment threadLib/test/test_descr.py Outdated
@eendebakpt
eendebakpt marked this pull request as ready for review February 17, 2026 22:55
@vstinner
vstinner merged commit dd64e42 into python:mainFeb 18, 2026
49 checks passed
@vstinner

vstinner commented Feb 18, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

@vstinner

vstinner commented Feb 19, 2026

Copy link
Copy Markdown
Member

Ah, the implementation doesn't work for recursive frozendict. I created #145027 to fix copy.deepcopy() for recursive frozendict.

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@eendebakpt@blurb-it
@vstinner@brijkapadia
pythongh-141510: Implement copy and deepcopy for frozendict (python#1…
583b9d7
…44905)
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@eendebakpt@blurb-it
@vstinner@ljfp
pythongh-141510: Implement copy and deepcopy for frozendict (python#1…
b47f161
…44905)
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eendebakpt@vstinner