Uh oh!
There was an error while loading. Please reload this page.
gh-141510: Optimize hash(frozendict) - #144919
Merged
Merged
Conversation
hash(frozendict) no longer creates a temporary items view and a temporary frozenset object. Copy frozenset_hash() code to frozendict_hash().
vstinner
requested review from
markshannon, methane and rhettinger
as code ownersFebruary 17, 2026 14:01
| Py_hash_t hash = FT_ATOMIC_LOAD_SSIZE_RELAXED(self->ma_hash); | ||
| if (hash != -1) { | ||
| return hash; | ||
| Py_hash_t shash = FT_ATOMIC_LOAD_SSIZE_RELAXED(self->ma_hash); |
MemberAuthor
There was a problem hiding this comment.
PyFrozenDictObject.ma_hash is mutable and so it needs a lock to handle properly concurrent access.
MemberAuthor
There was a problem hiding this comment.
It's the same for the Unicode strings hash: the string is immutable, but the hash member is mutable. So unicode_hash() uses atomic operations to get and set the hash member.
Contributor
There was a problem hiding this comment.
Yeah, the hash is "lazily" computed so we need to use relaxed atomics here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303
approved these changes
Feb 17, 2026
vstinner
commented
Feb 17, 2026
MemberAuthor
Merged, thanks for reviews! |
brijkapadia pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
hash(frozendict) no longer creates a temporary items view and a temporary frozenset object. Copy frozenset_hash() code to frozendict_hash().
ljfp pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
hash(frozendict) no longer creates a temporary items view and a temporary frozenset object. Copy frozenset_hash() code to frozendict_hash().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hash(frozendict) no longer creates a temporary items view and a temporary frozenset object.
Copy frozenset_hash() code to frozendict_hash().