Skip to content

gh-141510: Fix test_xpickle failing with introduction of frozendict - #144927

Merged
vstinner merged 1 commit into
python:mainfrom
StanFromIreland:test_xpickle
Feb 17, 2026
Merged

gh-141510: Fix test_xpickle failing with introduction of frozendict#144927
vstinner merged 1 commit into
python:mainfrom
StanFromIreland:test_xpickle

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Feb 17, 2026

Copy link
Copy Markdown
Member

Like #144878 just yesterday... we should start running this test somewhere.

@vstinnervstinner changed the title Fix test_xpickle failing with introduction of frozendictgh-141510: Fix test_xpickle failing with introduction of frozendictFeb 17, 2026

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm that ./python -m test test_xpickle -u xpickle fails without the change, and pass successfully with the change.

@vstinner
vstinner merged commit fa73fd4 into python:mainFeb 17, 2026
59 checks passed
@vstinner

Copy link
Copy Markdown
Member

Merged, thanks for the fix.

@StanFromIreland
StanFromIreland deleted the test_xpickle branch February 17, 2026 20:26
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Thanks for the review/merge.

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit fa73fd4.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/12367) and take a look at the build logs.
  4. Check if the failure is related to this commit (fa73fd4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/12367

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_repl_eio - test.test_pyrepl.test_unix_console.TestUnixConsoleEIOHandling.test_repl_eio

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1191, in __del__
_warn("subprocess %s is still running"%self.pid,
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ResourceWarning, source=self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ResourceWarning: subprocess 2393482 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in runwith outcome.testPartExecutor(self):
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='utf-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in runwith outcome.testPartExecutor(self):
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='utf-8'>
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/test_unix_console.py", line 390, in test_repl_eio
_, err = proc.communicate(timeout=support.LONG_TIMEOUT)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1273, in communicate
stdout, stderr =self._communicate(input, endtime, timeout)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 2293, in _communicateself._check_timeout(endtime, orig_timeout, stdout, stderr)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1320, in _check_timeoutraise TimeoutExpired(
...<2 lines>...
stderr=b''.join(stderr_seq) if stderr_seq elseNone)
subprocess.TimeoutExpired: Command '['/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/python', '-E', '-S', '/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/eio_test_script.py']' timed out after 300.0 seconds
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1191, in __del__
_warn("subprocess %s is still running"%self.pid,
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ResourceWarning, source=self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ResourceWarning: subprocess 2400081 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in runwith outcome.testPartExecutor(self):
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='utf-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in runwith outcome.testPartExecutor(self):
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='utf-8'>

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@vstinner@bedevere-bot