Skip to content

gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT - #144963

Merged
Fidget-Spinner merged 16 commits into
python:mainfrom
Sacul0457:Optimize_MAKE_FUNCTION
Apr 9, 2026
Merged

gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT#144963
Fidget-Spinner merged 16 commits into
python:mainfrom
Sacul0457:Optimize_MAKE_FUNCTION

Conversation

@Sacul0457

@Sacul0457Sacul0457 commented Feb 18, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Thanks to @Fidget-Spinner for guiding!

Adds _MAKE_FUNCTION to optimizer_bytecodes.c and eliminates redundant ref-counting for MAKE_FUNCTION.

@Fidget-Spinner

Fidget-Spinner commented Feb 18, 2026

Copy link
Copy Markdown
Member

MAKE_FUNCTION might not be a common opcode/show up in the JIT. So I doubt we will see speedups from this one, it's still good to add it to the optimizer though so thanks.

@bedevere-appbedevere-appBot mentioned this pull request Feb 18, 2026
Closed
35 tasks
markshannon
markshannon approved these changes Mar 12, 2026
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@Sacul0457 can you update this branch so it can be merged?

@Sacul0457

Sacul0457 commented Mar 13, 2026

Copy link
Copy Markdown
ContributorAuthor

I'm can't seem to find the error logs for the CI failure, so I'm not sure what's the cause of the failure and whether it's related to this PR or not

@Fidget-Spinner

Fidget-Spinner commented Mar 13, 2026

Copy link
Copy Markdown
Member

Sometimes the sanitizer CI is a little flaky, so I've triggered a re-run.

@Sacul0457

Sacul0457 commented Mar 13, 2026

Copy link
Copy Markdown
ContributorAuthor

Seems to pass now, thx!

@kumaraditya303

kumaraditya303 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

There are new merge conflicts.

@Sacul0457

Sacul0457 commented Mar 19, 2026

Copy link
Copy Markdown
ContributorAuthor

fixed :)

@savannahostrowski

savannahostrowski commented Apr 9, 2026

Copy link
Copy Markdown
Member

Looks like this needs another regen, mind resolving @Sacul0457?

@Sacul0457

Sacul0457 commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

Fixed!

@Fidget-Spinner

Fidget-Spinner commented Apr 9, 2026

Copy link
Copy Markdown
Member

Sorry this needs merging main again. JIT development has been very active these days 🌀

@Sacul0457

Sacul0457 commented Apr 9, 2026

Copy link
Copy Markdown
ContributorAuthor

No worries, it's great to hear how active the JIT development is :)

@Fidget-SpinnerFidget-Spinner mentioned this pull request Apr 9, 2026
Merged
@Fidget-Spinner
Fidget-Spinner merged commit 38d3aef into python:mainApr 9, 2026
77 checks passed
@Sacul0457
Sacul0457 deleted the Optimize_MAKE_FUNCTION branch April 10, 2026 16:20
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Sacul0457@ljfp
pythongh-134584: Optimize and eliminate redundant ref-counting for `…
b6dbcbb
…MAKE_FUNCTION` in the JIT (pythonGH-144963)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sacul0457@Fidget-Spinner@kumaraditya303@savannahostrowski@markshannon