Uh oh!
There was an error while loading. Please reload this page.
gh-145055: Accept frozendict for globals in exec() and eval() - #145072
Merged
Conversation
vstinner
marked this pull request as ready for review
March 3, 2026 11:18
vstinner
requested review from
brettcannon, ericsnowcurrently, kumaraditya303, markshannon, methane, ncoghlan and warsaw
as code ownersMarch 3, 2026 11:18
vstinner
commented
Mar 3, 2026
MemberAuthor
The PR is now ready for review. |
vstinner
commented
Mar 3, 2026
MemberAuthor
cc @skirpichev |
skirpichev
self-requested a review
March 3, 2026 11:40
vstinner
commented
Mar 3, 2026
MemberAuthor
It's still possible to modify builtins, unless builtins is declared as a # module __builtins__>>>fd=frozendict(__builtins__=__builtins__)
>>>exec("__builtins__.x = 1", fd, fd)
# dict __builtins__>>>fd=frozendict(__builtins__=__builtins__.__dict__)
>>>exec("__builtins__['x'] = 1", fd, fd)
# frozendict __builtins__>>>fd=frozendict(__builtins__=frozendict(__builtins__.__dict__))
>>>exec("__builtins__['x'] = 1", fd, fd)
Traceback (mostrecentcalllast):
...
TypeError: 'frozendict'objectdoesnotsupportitemassignment |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Mar 4, 2026
MemberAuthor
@skirpichev: I removed the sentence from the documentation, and I replaced it with a more precise error message if assigning |
skirpichev
self-requested a review
March 4, 2026 10:51
skirpichev
approved these changes
Mar 4, 2026
vstinner
commented
Mar 5, 2026
MemberAuthor
Merged. Thanks for the review @skirpichev. |
ljfp pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--145072.org.readthedocs.build/