Skip to content

gh-145118: Add frozendict support to type() - #145124

Merged
vstinner merged 3 commits into
python:mainfrom
StanFromIreland:builtins-dicts
Mar 2, 2026
Merged

gh-145118: Add frozendict support to type()#145124
vstinner merged 3 commits into
python:mainfrom
StanFromIreland:builtins-dicts

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Feb 22, 2026

Copy link
Copy Markdown
Member

Comment threadObjects/typeobject.c
Comment threadObjects/typeobject.c Outdated

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should write a separated PR to modify str.maketrans(). It's unrelated to the type change.

@StanFromIrelandStanFromIreland changed the title gh-145118: Add frozendict support to str.maketrans() and type()gh-145118: Add frozendict support to type()Feb 22, 2026
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Split to #145129.

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
vstinner merged commit f8d2f9f into python:mainMar 2, 2026
51 checks passed
@vstinner

Copy link
Copy Markdown
Member

Merged, thanks.

@StanFromIreland
StanFromIreland deleted the builtins-dicts branch March 2, 2026 19:45
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@vstinner@eendebakpt