Skip to content

GH-145247: Implement _PyTuple_FromPair - #145325

Merged
vstinner merged 20 commits into
python:mainfrom
sergey-miryanov:145247-pytuple-from-pair
Mar 10, 2026
Merged

GH-145247: Implement _PyTuple_FromPair#145325
vstinner merged 20 commits into
python:mainfrom
sergey-miryanov:145247-pytuple-from-pair

Conversation

@sergey-miryanov

@sergey-miryanovsergey-miryanov commented Feb 27, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Feb 27, 2026
Open
eendebakpt
eendebakpt reviewed Feb 28, 2026
View reviewed changes

@eendebakpteendebakpt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To minor comments on the test, but overall this looks good!

Comment threadLib/test/test_capi/test_tuple.py Outdated
Comment threadLib/test/test_capi/test_tuple.py Outdated
@sergey-miryanov@eendebakpt
Update Lib/test/test_capi/test_tuple.py
5862613
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
eendebakpt
eendebakpt reviewed Mar 1, 2026
View reviewed changes
Comment threadLib/test/test_capi/test_tuple.py Outdated
vstinner
vstinner reviewed Mar 4, 2026
View reviewed changes
Comment threadObjects/tupleobject.c Outdated
Comment threadModules/_testinternalcapi/tuple.c Outdated
Comment threadInclude/internal/pycore_tuple.h Outdated
Comment threadLib/test/test_capi/test_tuple.py Outdated
Comment threadLib/test/test_capi/test_tuple.py Outdated
Comment threadLib/test/test_capi/test_tuple.py Outdated
Comment threadModules/_testinternalcapi/tuple.c Outdated
sergey-miryanovand others added 3 commits March 5, 2026 10:32
@sergey-miryanov
Small fix - use items
f5ad4df
@sergey-miryanov@vstinner@eendebakpt
Apply suggestions from code review
1764785
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
@sergey-miryanov
Address review
63a3c4b
@sergey-miryanov

sergey-miryanov commented Mar 5, 2026

Copy link
Copy Markdown
ContributorAuthor

@eendebakpt@vstinner Thanks for review! Could you please take another look?

@sergey-miryanov
sergey-miryanov marked this pull request as ready for review March 5, 2026 20:57
johnslavik
johnslavik reviewed Mar 5, 2026
View reviewed changes

@johnslavikjohnslavik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to take a closer look soon.

Comment threadObjects/tupleobject.c Outdated
Comment threadObjects/tupleobject.c Outdated
@sergey-miryanov@johnslavik
Apply suggestions from code review
67bd5fc
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
vstinner
vstinner approved these changes Mar 6, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadObjects/tupleobject.c Outdated
kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadObjects/tupleobject.c Outdated
kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadObjects/tupleobject.c Outdated
kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadObjects/tupleobject.c Outdated
kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadObjects/tupleobject.c Outdated
sergey-miryanovand others added 3 commits March 7, 2026 16:26
@sergey-miryanov@kumaraditya303
Update Objects/tupleobject.c
53dad5b
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@sergey-miryanov
Address review
9d28667
@sergey-miryanov
Fix typo
b0a5ede
kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadModules/_testinternalcapi/tuple.c Outdated
kumaraditya303
kumaraditya303 reviewed Mar 7, 2026
View reviewed changes
Comment threadModules/_testinternalcapi/tuple.c Outdated
@sergey-miryanov

sergey-miryanov commented Mar 9, 2026

Copy link
Copy Markdown
ContributorAuthor

@markshannon Could you please take a look?

@vstinner
vstinner merged commit 478a315 into python:mainMar 10, 2026
66 checks passed
@vstinner

vstinner commented Mar 10, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@sergey-miryanov@eendebakpt
@vstinner@johnslavik@kumaraditya303@ljfp
pythonGH-145247: Implement _PyTuple_FromPair() (python#145325)
61b1409
Implement _PyTuple_FromPair() and _PyTuple_FromPairSteal().
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpteendebakpteendebakpt left review comments
@johnslavikjohnslavikjohnslavik left review comments
@vstinnervstinnervstinner approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergey-miryanov@vstinner@eendebakpt@kumaraditya303@johnslavik