Skip to content

gh-145334: Make lazy import tests discoverable - #145336

Merged
pablogsal merged 8 commits into
python:mainfrom
johnslavik:fix-test-layout-lazy-imports
Feb 28, 2026
Merged

gh-145334: Make lazy import tests discoverable#145336
pablogsal merged 8 commits into
python:mainfrom
johnslavik:fix-test-layout-lazy-imports

Conversation

@johnslavik

@johnslavikjohnslavik commented Feb 27, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Feb 27, 2026
Closed
@johnslavikjohnslavik changed the title gh-145334: Move test_import.test_lazy_imports to test.test_lazy_importgh-145334: Move test.test_import.test_lazy_imports to test.test_lazy_importFeb 27, 2026
@johnslavik

johnslavik commented Feb 27, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Conflicts. Sorry, I'll force-push this one time, practicality beats purity.

@johnslavik
johnslavik marked this pull request as draft February 27, 2026 23:34
@johnslavik
johnslavikforce-pushed the fix-test-layout-lazy-imports branch from cb2a385 to 78d584aCompareFebruary 27, 2026 23:38
@johnslavik
johnslavik marked this pull request as ready for review February 27, 2026 23:38
@AlexWaygood
AlexWaygood removed their request for review February 27, 2026 23:47
@brettcannon
brettcannon removed their request for review February 27, 2026 23:47
@johnslavikjohnslavik changed the title gh-145334: Move test.test_import.test_lazy_imports to test.test_lazy_importgh-145334: Make lazy import tests discoverableFeb 28, 2026
@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member

I have cloned this locally and run a bunch of checks to see that the new files make sense and we are not loosing anything here so I am satisfied. Thanks a lot @johnslavik! Great work 🥇

@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member

We should test with an installed python because of the makefile changes. Will do this now

@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member
$ ./configure --prefix=$PWD/inst -C
$ make install -j
$ main fix-test-layout-lazy-imports ? ❯ ./inst/bin/python3 -m test test_lazy_import
Using random seed: 2114320666
0:00:00 load avg: 7.47 Run 1 test sequentially in a single process
0:00:00 load avg: 7.47 [1/1] test_lazy_import
BAR_MODULE_LOADED
0:00:00 load avg: 7.47 [1/1] test_lazy_import passed
== Tests result: SUCCESS ==
1 test OK.
Total duration: 655 ms
Total tests: run=91
Total test files: run=1/1
Result: SUCCESS

@pablogsal

pablogsal commented Feb 28, 2026

Copy link
Copy Markdown
Member

We are golden

@pablogsal
pablogsal merged commit a66d518 into python:mainFeb 28, 2026
49 checks passed
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@johnslavik@brijkapadia
pythongh-145334: Make lazy import tests discoverable (python#145336)
2958b3c
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@johnslavik@ljfp
pythongh-145334: Make lazy import tests discoverable (python#145336)
4b41b9a
@johnslavik
johnslavik deleted the fix-test-layout-lazy-imports branch July 21, 2026 01:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes
@Yhg1sYhg1sAwaiting requested review from Yhg1sYhg1s is a code owner
@DinoVDinoVAwaiting requested review from DinoVDinoV is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
@webknjazwebknjazAwaiting requested review from webknjazwebknjaz is a code owner

Assignees

No one assigned

Labels

skip newstopic-lazy-imports

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnslavik@pablogsal@Yhg1s