Skip to content

gh-100538: Add workflow to verify bundled libexpat - #145359

Merged
gpshead merged 6 commits into
python:mainfrom
StanFromIreland:verify-expat
Mar 1, 2026
Merged

gh-100538: Add workflow to verify bundled libexpat#145359
gpshead merged 6 commits into
python:mainfrom
StanFromIreland:verify-expat

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Feb 28, 2026

Copy link
Copy Markdown
Member

@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

@hartworkhartwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanFromIreland makes sense to me! 👍

@hugovk

Copy link
Copy Markdown
Member

Is it worth combining this verify-expat.yml with the existing verify-ensurepip-wheels.yml?

@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Is it worth combining this verify-expat.yml with the existing verify-ensurepip-wheels.yml?

IMO, no. It won't save us much time (~5 seconds, but the workflow only takes a few (~10) seconds in total), and one check will always be unnecessarily run.

@gpsheadgpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this, useful!

@gpshead
gpshead merged commit c9a5d9a into python:mainMar 1, 2026
52 checks passed
@gpsheadgpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 1, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2026
…5359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2026
…5359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

Copy link
Copy Markdown

GH-145400 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Mar 1, 2026
@bedevere-app

Copy link
Copy Markdown

GH-145401 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 1, 2026
@gpshead

Copy link
Copy Markdown
Member

(if the backports work, i'll merge them, if not, no worries, having this in main is the most important part)

@StanFromIreland
StanFromIreland deleted the verify-expat branch March 1, 2026 19:50
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

having this in main is the most important part

I would suggest also the security branches, since they require manual backports?

gpshead pushed a commit that referenced this pull request Mar 1, 2026
…#145400)
gh-100538: Add workflow to verify bundled libexpat (GH-145359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request Mar 1, 2026
…#145401)
gh-100538: Add workflow to verify bundled libexpat (GH-145359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@gpsheadgpshead added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 2, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
…5359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
…5359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

Copy link
Copy Markdown

GH-145407 is a backport of this pull request to the 3.10 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.10 only security fixes label Mar 2, 2026
@bedevere-app

Copy link
Copy Markdown

GH-145408 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Mar 2, 2026
@bedevere-app

Copy link
Copy Markdown

GH-145409 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Mar 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
…5359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Mar 2, 2026
…#145407)
gh-100538: Add workflow to verify bundled libexpat (GH-145359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Mar 2, 2026
…#145408)
gh-100538: Add workflow to verify bundled libexpat (GH-145359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Mar 2, 2026
…#145409)
gh-100538: Add workflow to verify bundled libexpat (GH-145359)
Add workflow to verify bundled libexpat.
(cherry picked from commit c9a5d9a)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@hugovk@gpshead@hartwork