Skip to content

gh-145376: Fix various reference leaks - #145377

Merged
encukou merged 1 commit into
python:mainfrom
JelleZijlstra:refcount-bugs
Mar 3, 2026
Merged

gh-145376: Fix various reference leaks#145377
encukou merged 1 commit into
python:mainfrom
JelleZijlstra:refcount-bugs

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Mar 1, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 1, 2026
Closed
@JelleZijlstraJelleZijlstra added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 1, 2026
sobolevn
sobolevn reviewed Mar 1, 2026
View reviewed changes
Comment threadPython/crossinterp.c
@zware

zware commented Mar 1, 2026

Copy link
Copy Markdown
Member

Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :)

@JelleZijlstra

JelleZijlstra commented Mar 1, 2026

Copy link
Copy Markdown
MemberAuthor

I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like.

@zware

zware commented Mar 2, 2026

Copy link
Copy Markdown
Member

I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it.

@encukou
encukou merged commit bd13cc0 into python:mainMar 3, 2026
57 checks passed
@miss-islington-app

miss-islington-appBot commented Mar 3, 2026

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Mar 3, 2026

Copy link
Copy Markdown

Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.14

@miss-islington-app

miss-islington-appBot commented Mar 3, 2026

Copy link
Copy Markdown

Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.13

@bedevere-app

bedevere-appBot commented Mar 9, 2026

Copy link
Copy Markdown

GH-145712 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 9, 2026
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Mar 9, 2026
@JelleZijlstra@StanFromIreland
[3.14]pythongh-145376: Fix various reference leaks (pythonGH-145377)
9db9080
(cherry picked from commit bd13cc0)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
encukou pushed a commit that referenced this pull request Mar 10, 2026
@StanFromIreland@JelleZijlstra
[3.14]gh-145376: Fix various reference leaks (GH-145377) (GH-145712)
6d9221c
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Apr 16, 2026
@JelleZijlstra@StanFromIreland
[3.13]pythongh-145376: Fix various reference leaks (pythonGH-145377)
73d767b
(cherry picked from commit bd13cc0)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app

bedevere-appBot commented Apr 16, 2026

Copy link
Copy Markdown

GH-148661 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 16, 2026
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@JelleZijlstra@ljfp
pythongh-145376: Fix various reference leaks (pythonGH-145377)
65bf9be
StanFromIreland added a commit that referenced this pull request May 12, 2026
@StanFromIreland@JelleZijlstra
[3.13]gh-145376: Fix various reference leaks (GH-145377) (#148661)
ea8c3e0
(cherry picked from commit bd13cc0)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments
@sergey-miryanovsergey-miryanovsergey-miryanov approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

@encukouencukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JelleZijlstra@zware@sergey-miryanov@sobolevn@kumaraditya303@encukou