Skip to content

gh-145335: Skip Emscripten for os.execve test - #145528

Merged
vstinner merged 2 commits into
python:mainfrom
hoodmane:skip-execve-emscripten
Mar 5, 2026
Merged

gh-145335: Skip Emscripten for os.execve test#145528
vstinner merged 2 commits into
python:mainfrom
hoodmane:skip-execve-emscripten

Conversation

@hoodmane

@hoodmanehoodmane commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Emscripten's os.execve always fails with ENOEXEC. As an alternative, we could add
ENOEXEC to the list of allowed return codes.

@hoodmane
pythongh-145335: Skip Emscripten for os.execve test
8c1b9f4
Emscripten's os.execve always fails with ENOEXEC.
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Mar 5, 2026
@hoodmanehoodmane added skip news and removed tests Tests in the Lib/test dir labels Mar 5, 2026
@bedevere-appbedevere-appBot mentioned this pull request Mar 5, 2026
Closed
@hoodmane
hoodmane requested a review from vstinnerMarch 5, 2026 10:11
@hoodmanehoodmane mentioned this pull request Mar 5, 2026
Merged
vstinner
vstinner reviewed Mar 5, 2026
View reviewed changes
Comment threadLib/test/test_os/test_os.py Outdated
@hoodmane@vstinner
Update Lib/test/test_os/test_os.py
4e57790
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
vstinner merged commit 23a4e3b into python:mainMar 5, 2026
81 of 83 checks passed
@vstinner

vstinner commented Mar 5, 2026

Copy link
Copy Markdown
Member

Merged, thanks for the fix.

@hoodmane
hoodmane deleted the skip-execve-emscripten branch March 9, 2026 10:47
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hoodmane@vstinner@ljfp
pythongh-145335: Skip Emscripten for os.execve() test (python#145528)
9d93f19
Emscripten's os.execve() always fails with ENOEXEC.
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane@vstinner