Skip to content

bpo-37421: test_concurrent_futures cleans up multiprocessing - #14563

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:test_concurrent_futures_cleanup
Jul 3, 2019
Merged

bpo-37421: test_concurrent_futures cleans up multiprocessing#14563
vstinner merged 1 commit into
python:masterfrom
vstinner:test_concurrent_futures_cleanup

Conversation

@vstinner

@vstinnervstinner commented Jul 2, 2019

Copy link
Copy Markdown
Member

test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().

The test now uses setUpModule() and tearDownModule().

https://bugs.python.org/issue37421

test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().
The test now uses setUpModule() and tearDownModule().

if __name__ == "__main__":
test_main()
unittest.main()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👍

@vstinner
vstinner merged commit 684cb47 into python:masterJul 3, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@vstinner
vstinner deleted the test_concurrent_futures_cleanup branch July 3, 2019 09:10
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2019
…H-14563)
test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().
The test now uses setUpModule() and tearDownModule().
(cherry picked from commit 684cb47)
Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot

Copy link
Copy Markdown

GH-14570 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jul 3, 2019
test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().
The test now uses setUpModule() and tearDownModule().
(cherry picked from commit 684cb47)
Co-authored-by: Victor Stinner <vstinner@redhat.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…H-14563)
test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().
The test now uses setUpModule() and tearDownModule().
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…H-14563)
test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().
The test now uses setUpModule() and tearDownModule().
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@miss-islington@bedevere-bot@zware@the-knights-who-say-ni