Skip to content

gh-145685: Update find_name_in_mro() to return a _PyStackRef (gh-145693) - #145693

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-145685-find-name-in-mro
Mar 10, 2026
Merged

gh-145685: Update find_name_in_mro() to return a _PyStackRef (gh-145693)#145693
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-145685-find-name-in-mro

Conversation

@colesbury

@colesburycolesbury commented Mar 9, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This is the first of a few PRs to fix the scaling bottleneck in _PyType_LookupStackRefAndVersion.

@bedevere-appbedevere-appBot mentioned this pull request Mar 9, 2026
Closed
@colesbury

colesbury commented Mar 9, 2026

Copy link
Copy Markdown
ContributorAuthor

NEWS entry will be included in a follow-up when the scaling problem is fixed.

@colesbury
colesbury marked this pull request as ready for review March 9, 2026 18:25
@colesbury
colesbury requested a review from mpageMarch 9, 2026 18:25
@colesburycolesbury changed the title gh-145685: Update find_name_in_mro() to return a _PyStackRefgh-145685: Update find_name_in_mro() to return a _PyStackRef (gh-145693)Mar 10, 2026
@colesbury
colesbury merged commit f26eca7 into python:mainMar 10, 2026
98 of 100 checks passed
@miss-islington-app

miss-islington-appBot commented Mar 10, 2026

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
@colesbury@miss-islington
pythongh-145685: Update find_name_in_mro() to return a _PyStackRef (p…
e28d08b
…ythongh-145693)
(cherry picked from commit f26eca7)
Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-appBot commented Mar 10, 2026

Copy link
Copy Markdown

GH-145769 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 10, 2026
@colesbury
colesbury deleted the gh-145685-find-name-in-mro branch March 10, 2026 17:04
colesbury added a commit that referenced this pull request Mar 10, 2026
@miss-islington@colesbury
[3.14]gh-145685: Update find_name_in_mro() to return a _PyStackRef (g…
e7bc152
…h-145693) (#145769)
(cherry picked from commit f26eca7)
Co-authored-by: Sam Gross <colesbury@gmail.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@colesbury@ljfp
pythongh-145685: Update find_name_in_mro() to return a _PyStackRef (p…
a56003c
…ythongh-145693)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpagempagempage approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@mpage