Uh oh!
There was an error while loading. Please reload this page.
gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format - #145756
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
JelleZijlstra
commented
Mar 10, 2026
This change looks right to me, please add a unit test and we'll hopefully get it merged! |
mschoettle
commented
Mar 18, 2026
Thanks, @JelleZijlstra! I added a unit test. Are you able to review it or does it require @cjw296 as the code owner? |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Sorry, looks like I never submitted this review.
I am comfortable merging this once I'm happy with the code.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Thanks @mschoettle for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…orwardref annotation format (pythonGH-145756) (cherry picked from commit d357a7d) Co-authored-by: Matthias Schoettle <git@mattsch.com>
GH-146191 is a backport of this pull request to the 3.14 branch. |
bedevere-bot
commented
Mar 20, 2026
|
* upstream/main: (1475 commits) Docs: replace all `datetime` imports with `import datetime as dt` (python#145640) pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154) pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536) pythongh-140947: fix contextvars handling for server tasks in asyncio (python#141158) pythonGH-100108: Add async generators best practices section (python#141885) pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120) pythongh-146228: Better fork support in cached FastPath (python#146231) pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229) pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230) pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165) pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396) pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201) pythongh-143930: Reject leading dashes in webbrowser URLs pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919) pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206) pythongh-146171: Fix nested AttributeError suggestions (python#146188) pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101) pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981) pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756) pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160) ...
…orwardref annotation format (python#145756)
Uses annotation format
FORWARDREFinstead of the defaultVALUEwhen callinginspect.signature.STRINGalso seems to work but affects existing tests that check the signature.unittest.mockis less robust with PEP 649 #145754Closes#145754