Skip to content

gh-142518: Annotate PyDict_* C APIs for thread safety - #145875

Merged
kumaraditya303 merged 8 commits into
python:mainfrom
lysnikolaou:annotate-pydict
Apr 10, 2026
Merged

gh-142518: Annotate PyDict_* C APIs for thread safety#145875
kumaraditya303 merged 8 commits into
python:mainfrom
lysnikolaou:annotate-pydict

Conversation

@lysnikolaou

@lysnikolaoulysnikolaou commented Mar 12, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 12, 2026
Closed
@lysnikolaoulysnikolaou mentioned this pull request Mar 13, 2026
Open
50 tasks
kumaraditya303
kumaraditya303 reviewed Mar 13, 2026
View reviewed changes
Comment threadDoc/data/threadsafety.dat
encukou
encukou reviewed Mar 25, 2026
View reviewed changes
Comment threadDoc/c-api/dict.rst Outdated
encukou
encukou reviewed Apr 3, 2026
View reviewed changes
Comment threadDoc/c-api/dict.rst Outdated
vstinner
vstinner approved these changes Apr 10, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadDoc/data/threadsafety.dat Outdated
Comment threadDoc/c-api/dict.rst Outdated
kumaraditya303and others added 2 commits April 11, 2026 00:02
@kumaraditya303@vstinner
Update Doc/data/threadsafety.dat
9cacc03
Co-authored-by: Victor Stinner <vstinner@python.org>
@kumaraditya303
mention bool & bytes
54a8c33
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) April 10, 2026 18:35
@kumaraditya303
kumaraditya303 merged commit 15d10a8 into python:mainApr 10, 2026
30 checks passed
@miss-islington-app

miss-islington-appBot commented Apr 10, 2026

Copy link
Copy Markdown

Thanks @lysnikolaou for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Apr 10, 2026

Copy link
Copy Markdown

Sorry, @lysnikolaou and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 15d10a82439e2a83cb004dd16786b168e82cba2e 3.14

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@lysnikolaou@ljfp
pythongh-142518: annotate dict C-APIs for thread safety (python#145875)
5a67bf5
@StanFromIreland

StanFromIreland commented Jun 5, 2026

Copy link
Copy Markdown
Member

Backported to 3.14 in #148392.

@StanFromIrelandStanFromIreland removed the needs backport to 3.14 bugs and security fixes label Jun 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments
@vstinnervstinnervstinner approved these changes
@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity is a code owner
@encukouencukouAwaiting requested review from encukou
+1 more reviewer
@clin1234clin1234clin1234 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@kumaraditya303kumaraditya303

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lysnikolaou@StanFromIreland@vstinner@encukou@clin1234@kumaraditya303