Skip to content

gh-141510: Avoid critical section on frozendict copy#145920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Mar 16, 2026
Merged

gh-141510: Avoid critical section on frozendict copy #145920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
836ad73
gh-141510: Avoid critical section on frozendict copy
vstinner Mar 5, 2026
02fe87f
Fix assertion in clone_combined_dict_keys()
vstinner Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions Objects/dictobject.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -968,7 +968,9 @@ clone_combined_dict_keys(PyDictObject *orig)
assert(orig->ma_keys != Py_EMPTY_KEYS);
assert(orig->ma_keys->dk_refcnt == 1);

ASSERT_DICT_LOCKED(orig);
if (!PyFrozenDict_Check(orig)) {
ASSERT_DICT_LOCKED(orig);
}

size_t keys_size = _PyDict_KeysSize(orig->ma_keys);
PyDictKeysObject *keys = PyMem_Malloc(keys_size);
Expand DownExpand Up@@ -4322,7 +4324,10 @@ copy_lock_held(PyObject *o, int as_frozendict)
PyObject *copy;
PyDictObject *mp;

ASSERT_DICT_LOCKED(o);
// frozendict is immutable and so doesn't need critical section
if (!PyFrozenDict_Check(o)) {
ASSERT_DICT_LOCKED(o);
}

mp = (PyDictObject *)o;
if (mp->ma_used == 0) {
Expand DownExpand Up@@ -4445,9 +4450,14 @@ anydict_copy(PyObject *o)
assert(PyAnyDict_Check(o));

PyObject *res;
Py_BEGIN_CRITICAL_SECTION(o);
res = copy_lock_held(o, PyFrozenDict_Check(o));
Py_END_CRITICAL_SECTION();
if (PyFrozenDict_Check(o)) {
res = copy_lock_held(o, 1);
}
else {
Py_BEGIN_CRITICAL_SECTION(o);
res = copy_lock_held(o, 0);
Py_END_CRITICAL_SECTION();
}
return res;
}

Expand All@@ -4459,9 +4469,14 @@ _PyDict_CopyAsDict(PyObject *o)
assert(PyAnyDict_Check(o));

PyObject *res;
Py_BEGIN_CRITICAL_SECTION(o);
res = copy_lock_held(o, 0);
Py_END_CRITICAL_SECTION();
if (PyFrozenDict_Check(o)) {
res = copy_lock_held(o, 0);
}
else {
Py_BEGIN_CRITICAL_SECTION(o);
res = copy_lock_held(o, 0);
Py_END_CRITICAL_SECTION();
}
return res;
}

Expand Down
Loading