Skip to content

Remove PDF images - #145977

Merged
hugovk merged 4 commits into
python:mainfrom
StanFromIreland:remove-pdf
Jul 5, 2026
Merged

Remove PDF images#145977
hugovk merged 4 commits into
python:mainfrom
StanFromIreland:remove-pdf

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Mar 15, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

With #145480, these will be automatically converted if necessary.

📚 Documentation preview 📚: https://cpython-previews--145977.org.readthedocs.build/

@StanFromIreland

StanFromIreland commented Mar 15, 2026

Copy link
Copy Markdown
MemberAuthor

CC @m-aciek

@StanFromIreland

StanFromIreland commented Mar 15, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

EPUB is failing, but it has always used the SVG? I'll try figure it out.

Edit: It seems .. only:: html is in fact, not only HTML.

m-aciek
m-aciek reviewed Mar 17, 2026
View reviewed changes

@m-aciekm-aciek left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use builder_ prefix for readabilitydisambiguity.

Comment threadDoc/c-api/lifecycle.rst Outdated
Comment threadDoc/c-api/lifecycle.rst Outdated
@github-actions

This comment was marked as spam.

Sign in to view
@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label May 17, 2026
StanFromIrelandand others added 2 commits June 22, 2026 21:06
@StanFromIreland

StanFromIreland commented Jun 22, 2026

Copy link
Copy Markdown
MemberAuthor

Good catch, thanks @m-aciek!

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Jun 23, 2026
@m-aciek

m-aciek commented Jul 4, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

For the record, triggered builds of offline docs formats (including PDF) to make sure it passes: https://github.com/m-aciek/python-docs-offline/actions/runs/28710825478

m-aciek
m-aciek reviewed Jul 4, 2026
View reviewed changes

@m-aciekm-aciek left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, builds passed successfully. I cannot approve at GH PR level.

Only users with explicit access to this repository may approve pull requests

@hugovk

hugovk commented Jul 5, 2026

Copy link
Copy Markdown
Member

This looks good to me, builds passed successfully.

Thanks for testing!

I cannot approve at GH PR level.

Only users with explicit access to this repository may approve pull requests

Yeah, we turned that off after getting spam reviews. Your approval comment is appreciated!

@hugovk
hugovk merged commit 5616505 into python:mainJul 5, 2026
51 of 53 checks passed
@hugovkhugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 5, 2026
@miss-islington-app

miss-islington-appBot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 5, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5616505b443b13d9f5766dedcf6c0b43167705b6 3.13

@bedevere-app

bedevere-appBot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153064 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 5, 2026
@bedevere-app

bedevere-appBot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153065 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2026
@m-aciek

m-aciek commented Jul 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This shouldn't be backported to 3.13, as we support SVG conversion for 3.14+. #139588

Hm, I think I may be wrong, lifecycle graphics probably were added for 3.14. And turtle star were superfluous earlier -- there's the PNG format.

@StanFromIreland
StanFromIreland deleted the remove-pdf branch July 5, 2026 08:15
@StanFromIreland

StanFromIreland commented Jul 5, 2026

Copy link
Copy Markdown
MemberAuthor

Since there are also conflicts, I think we can skip the backport.

@StanFromIrelandStanFromIreland removed the needs backport to 3.13 bugs and security fixes label Jul 5, 2026
StanFromIreland added a commit that referenced this pull request Jul 5, 2026
@miss-islington@StanFromIreland@m-aciek
[3.15] Remove PDF images (GH-145977) (#153064)
f8d7ae8
(cherry picked from commit 5616505)
Co-authored-by: Stan Ulbrych <stan@python.org>
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
StanFromIreland added a commit that referenced this pull request Jul 5, 2026
@miss-islington@StanFromIreland@m-aciek
[3.14] Remove PDF images (GH-145977) (#153065)
33396b9
(cherry picked from commit 5616505)
Co-authored-by: Stan Ulbrych <stan@python.org>
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity is a code owner
@hugovkhugovkAwaiting requested review from hugovk
1 more reviewer
@m-aciekm-aciekm-aciek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@hugovkhugovk

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@m-aciek@hugovk