Skip to content

gh-146076: Fix crash when a ZoneInfo subclass is missing a _weak_cache - #146082

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
StanFromIreland:zoneinfo-weakcacghe
Mar 18, 2026
Merged

gh-146076: Fix crash when a ZoneInfo subclass is missing a _weak_cache#146082
kumaraditya303 merged 2 commits into
python:mainfrom
StanFromIreland:zoneinfo-weakcacghe

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Mar 17, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 17, 2026
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Mar 18, 2026
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@kumaraditya303
kumaraditya303 merged commit 3b06d68 into python:mainMar 18, 2026
56 checks passed
@StanFromIreland
StanFromIreland deleted the zoneinfo-weakcacghe branch March 18, 2026 13:46
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 18, 2026
@miss-islington-app

miss-islington-appBot commented Mar 18, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Mar 18, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2026
@StanFromIreland@miss-islington
pythongh-146076: Fix crash when aZoneInfosubclass is missing a `_…
31b2e50
…weak_cache` (pythonGH-146082)
(cherry picked from commit 3b06d68)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2026
@StanFromIreland@miss-islington
pythongh-146076: Fix crash when aZoneInfosubclass is missing a `_…
c9ac70f
…weak_cache` (pythonGH-146082)
(cherry picked from commit 3b06d68)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Mar 18, 2026

Copy link
Copy Markdown

GH-146115 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2026
@bedevere-app

bedevere-appBot commented Mar 18, 2026

Copy link
Copy Markdown

GH-146116 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 18, 2026
serhiy-storchaka pushed a commit that referenced this pull request Mar 18, 2026
@miss-islington@StanFromIreland
[3.13]gh-146076: Fix crash when aZoneInfosubclass is missing a `…
450e9ea
…_weak_cache` (GH-146082) (GH-146115)
(cherry picked from commit 3b06d68)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Mar 18, 2026
@miss-islington@StanFromIreland
[3.14]gh-146076: Fix crash when aZoneInfosubclass is missing a `…
6980b94
…_weak_cache` (GH-146082) (GH-146116)
(cherry picked from commit 3b06d68)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland

StanFromIreland commented Mar 18, 2026

Copy link
Copy Markdown
MemberAuthor

Thanks for the reviews and backports!

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@StanFromIreland@ljfp
pythongh-146076: Fix crash when aZoneInfosubclass is missing a `_…
a597827
…weak_cache` (python#146082)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@serhiy-storchaka@kumaraditya303