Uh oh!
There was an error while loading. Please reload this page.
gh-81773: Avoid parsing sys.version string in sysconfig - #146149
Closed
vstinner wants to merge 6 commits into
Closed
gh-81773: Avoid parsing sys.version string in sysconfig#146149vstinner wants to merge 6 commits into
vstinner wants to merge 6 commits into
Conversation
No longer parse sys.version string to create sysconfig._PY_VERSION. Add _sysconfig._PY_VERSION constant.
vstinner
commented
Mar 19, 2026
MemberAuthor
cc @FFY00 |
* Move also py_version_short and py_version_nodot to _sysconfig. * Use _sysconfig.config_vars() on all platforms, no only Windows.
vstinner
commented
Mar 23, 2026
Comment on lines
-534
to
-535
| _CONFIG_VARS['py_version_short'] = _PY_VERSION_SHORT | ||
| _CONFIG_VARS['py_version_nodot'] = _PY_VERSION_SHORT_NO_DOT |
MemberAuthor
There was a problem hiding this comment.
I'm not sure if it's worth it to move py_version_short and py_version_nodot to _sysconfig, since they can be easily built in Python.
MemberAuthor
There was a problem hiding this comment.
I reverted py_version_short and py_version_nodot changes.
vstinner
commented
Mar 24, 2026
MemberAuthor
Ping @FFY00. |
vstinner
commented
Mar 26, 2026
MemberAuthor
I'm not longer sure that this change is worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer parse sys.version string to create sysconfig._PY_VERSION. Add
_sysconfig.PY_VERSIONconstant.