Skip to content

gh-146250: Fix memory leak in re-initialization of SyntaxError - #146251

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
brijkapadia:syntax-error-leak
Mar 27, 2026
Merged

gh-146250: Fix memory leak in re-initialization of SyntaxError#146251
kumaraditya303 merged 6 commits into
python:mainfrom
brijkapadia:syntax-error-leak

Conversation

@brijkapadia

@brijkapadiabrijkapadia commented Mar 21, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Added Py_XDECREF/Py_XSETREF to avoid a memory leak when calling SyntaxError.__init__.

@brijkapadia
pythongh-146250: Fix memory leak of re-initialization ofSyntaxError
9370f4f
Added `Py_XDECREF`/`Py_XSETREF` to avoid a memory leak when calling
`SyntaxError.__init__`.
@bedevere-appbedevere-appBot mentioned this pull request Mar 21, 2026
Closed
aisk
aisk reviewed Mar 21, 2026
View reviewed changes
Comment threadMisc/NEWS.d/next/Core_and_Builtins/2026-03-21-11-55-16.gh-issue-146250.ahl3O2.rst Outdated
picnixz
picnixz reviewed Mar 21, 2026
View reviewed changes
Comment threadLib/test/test_exceptions.py Outdated
Comment threadLib/test/test_exceptions.py Outdated
Comment threadObjects/exceptions.c Outdated
Comment threadObjects/exceptions.c Outdated
@brijkapadia@aisk@picnixz
Apply suggestions from code review
f66f5ae
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz

picnixz commented Mar 21, 2026

Copy link
Copy Markdown
Member

Sorry about the Py_CLEAR suggestion but I think creating new variables would be cleaner.

@brijkapadia

brijkapadia commented Mar 21, 2026

Copy link
Copy Markdown
ContributorAuthor

What's wrong with using Py_CLEAR?

@picnixz

picnixz commented Mar 21, 2026

Copy link
Copy Markdown
Member

I think it is just better to hold temp vars and use XSETREF like in AttributeError.__init__

brijkapadia
brijkapadia commented Mar 21, 2026
View reviewed changes
Comment threadObjects/exceptions.c Outdated
picnixz
picnixz reviewed Mar 21, 2026
View reviewed changes
Comment threadLib/test/test_exceptions.py
@picnixz

picnixz commented Mar 21, 2026

Copy link
Copy Markdown
Member

I will test the refleak bots so don't commit anything until they are done!

@picnixzpicnixz added 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 21, 2026
@bedevere-bot

bedevere-bot commented Mar 21, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 22cff11 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146251%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 21, 2026
vstinner
vstinner approved these changes Mar 27, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm that the added test leaks without the fix, and doesn't leak with the fix.

@kumaraditya303
kumaraditya303 merged commit 0de4e08 into python:mainMar 27, 2026
73 checks passed
@miss-islington-app

miss-islington-appBot commented Mar 27, 2026

Copy link
Copy Markdown

Thanks @bkap123 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2026
@brijkapadia@miss-islington
pythongh-146250: Fix memory leak in re-initialization ofSyntaxError(
fcb10a5
pythonGH-146251)
(cherry picked from commit 0de4e08)
Co-authored-by: Brij Kapadia <97006829+bkap123@users.noreply.github.com>
@miss-islington-app

miss-islington-appBot commented Mar 27, 2026

Copy link
Copy Markdown

Sorry, @bkap123 and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0de4e08a5990e4692feb1b1ea01c303e468a2894 3.13

@bedevere-app

bedevere-appBot commented Mar 27, 2026

Copy link
Copy Markdown

GH-146517 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 27, 2026
@brijkapadia
brijkapadia deleted the syntax-error-leak branch March 27, 2026 14:22
@bedevere-app

bedevere-appBot commented Mar 27, 2026

Copy link
Copy Markdown

GH-146519 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2026
kumaraditya303 pushed a commit that referenced this pull request Mar 30, 2026
@aisk@brijkapadia
[3.13]gh-146250: Fix memory leak in re-initialization of `SyntaxErro…
c09ccd9
…r` (GH-146251) (#146519)
* [3.13] gh-146250: Fix memory leak in re-initialization of `SyntaxError` (GH-146251)
(cherry picked from commit 0de4e08)
Co-authored-by: Brij Kapadia <97006829+bkap123@users.noreply.github.com>
* Minimize the changes
* Minimize the changes
* Minimize the changes
---------
Co-authored-by: Brij Kapadia <97006829+bkap123@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Mar 30, 2026
@miss-islington@brijkapadia
[3.14]gh-146250: Fix memory leak in re-initialization of `SyntaxErro…
3c434f7
…r` (GH-146251) (#146517)
Co-authored-by: Brij Kapadia <97006829+bkap123@users.noreply.github.com>
@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@brijkapadia@clin1234
pythongh-146250: Fix memory leak in re-initialization ofSyntaxError(
d8f9f4b
python#146251)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@brijkapadia@ljfp
pythongh-146250: Fix memory leak in re-initialization ofSyntaxError(
b723bfa
python#146251)
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 1, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aiskaiskaisk left review comments
@picnixzpicnixzpicnixz left review comments
@vstinnervstinnervstinner approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees

@kumaraditya303kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brijkapadia@picnixz@bedevere-bot@vstinner@aisk@kumaraditya303