Skip to content

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version - #146338

Merged
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:gh146210
Apr 3, 2026
Merged

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version#146338
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:gh146210

Conversation

@chris-eibl

@chris-eiblchris-eibl commented Mar 23, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

By dropping the environment variable INCLUDE when building the jit stencils. Since this is Windows specific, this is only done on Windows.

@chris-eibl
fix building the jit stencils on Windows when the
390cc8a
interpreter is built with a different clang version.
@bedevere-appbedevere-appBot mentioned this pull request Mar 23, 2026
Closed
savannahostrowski
savannahostrowski requested changes Apr 3, 2026
View reviewed changes

@savannahostrowskisavannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this!

Comment threadTools/jit/_llvm.py Outdated
Comment threadTools/jit/_llvm.py
@bedevere-app

bedevere-appBot commented Apr 3, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

savannahostrowski
savannahostrowski approved these changes Apr 3, 2026
View reviewed changes

@savannahostrowskisavannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@savannahostrowski
savannahostrowski merged commit dea4083 into python:mainApr 3, 2026
78 checks passed
@chris-eibl
chris-eibl deleted the gh146210 branch April 3, 2026 19:43
@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@chris-eibl@savannahostrowski@ljfp
pythonGH-146210: Fix building the jit stencils on Windows when the in…
443237d
…terpreter is built with a different clang version (python#146338)
Co-authored-by: Savannah Ostrowski <savannah@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowskisavannahostrowskisavannahostrowski approved these changes
@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner
@diegorussodiegorussoAwaiting requested review from diegorussodiegorusso is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-eibl@savannahostrowski