Uh oh!
There was an error while loading. Please reload this page.
gh-146388: Add null check for sym_new(ctx) in make_bottom - #146389
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
aisk
commented
Mar 26, 2026
I think this fix is simple enough which doesn't requires a test, but the news entry is required. Can you add it follow the Dev Guide? https://devguide.python.org/getting-started/pull-request-lifecycle/#updating-news-and-what-s-new-in-python |
A0su
commented
Mar 26, 2026
@aisk, blurb added. Thanks for the review! |
| @@ -0,0 +1 @@ | |||
| Add a null check for :func:`sym_new(ctx)` in :func:`make_bottom` | |||
There was a problem hiding this comment.
This doesn't tell much. Can it be more descriptive please? Something like
Handle when JIT optimizer runs out of space when dealing with contradictions.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: AN Long <aisk@users.noreply.github.com>
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure that the NEWS entry is worth it, it's a corner case which is unlikely to occur in practice, no?
Uh oh!
There was an error while loading. Please reload this page.
optimizer_symbols.c: make_bottom NULL deref when arena full
sym_new(ctx)at line 1535 can return NULL when the type arena is full. Result immediately dereferenced without check. Every othersym_newcall site checks for NULL.This is a sub-issue of #146102 with gist details
optimizer_symbols.c:make_bottomNULL deref when arena full #146388