Skip to content

gh-142518: add thread safety docs on bytes C-API - #146415

Merged
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:bytes
Mar 27, 2026
Merged

gh-142518: add thread safety docs on bytes C-API#146415
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:bytes

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Mar 25, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Mar 25, 2026
Closed
vstinner
vstinner reviewed Mar 25, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buffer should not be mutated

Would it better to use must instead? "the buffer must not be mutated".

Or are there some legit use cases to mutate a buffer during a PyBytes function call?

See: https://datatracker.ietf.org/doc/html/rfc2119 for MUST vs SHOULD in RFC.

@kumaraditya303

kumaraditya303 commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

Would it better to use must instead? "the buffer must not be mutated".

Yes, I agree, changed it to "must" instead.

vstinner
vstinner reviewed Mar 27, 2026
View reviewed changes
Comment threadDoc/data/threadsafety.dat Outdated
@kumaraditya303

kumaraditya303 commented Mar 27, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@vstinner I updated the comment to avoid confusion, PTAL at the latest change.

vstinner
vstinner approved these changes Mar 27, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303
kumaraditya303 merged commit 6a94980 into python:mainMar 27, 2026
33 checks passed
@kumaraditya303
kumaraditya303 deleted the bytes branch March 27, 2026 13:01
@kumaraditya303kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Mar 27, 2026
@miss-islington-app

miss-islington-appBot commented Mar 27, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2026
@kumaraditya303@miss-islington
pythongh-142518: add thread safety docs on bytes C-API (pythonGH-146415)
15a2b18
(cherry picked from commit 6a94980)
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app

bedevere-appBot commented Mar 27, 2026

Copy link
Copy Markdown

GH-146515 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 27, 2026
kumaraditya303 added a commit that referenced this pull request Mar 27, 2026
@miss-islington@kumaraditya303
[3.14]gh-142518: add thread safety docs on bytes C-API (GH-146415) (#…
67862fc
…146515)
gh-142518: add thread safety docs on bytes C-API (GH-146415)
(cherry picked from commit 6a94980)
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@kumaraditya303@clin1234
pythongh-142518: add thread safety docs on bytes C-API (python#146415)
19820cf
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@kumaraditya303@ljfp
pythongh-142518: add thread safety docs on bytes C-API (python#146415)
1e64a09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity is a code owner
@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumaraditya303@vstinner