Skip to content

gh-146541: Allow building the Android testbed for 32-bit targets - #146542

Merged
freakboy3742 merged 3 commits into
python:mainfrom
robertkirkman:32-bit-android-testbed
Apr 4, 2026
Merged

gh-146541: Allow building the Android testbed for 32-bit targets#146542
freakboy3742 merged 3 commits into
python:mainfrom
robertkirkman:32-bit-android-testbed

Conversation

@robertkirkman

@robertkirkmanrobertkirkman commented Mar 28, 2026•
edited by mhsmith
Loading

Copy link
Copy Markdown
Contributor

This allows building the Android testbed for 32-bit targets using the prebuilt 32-bit dependencies that are already available here: https://github.com/beeware/cpython-android-source-deps/releases , adding the target triplets to match them, arm-linux-androideabi and i686-linux-android.

This also adds the arm key to the dictionary used to convert the machine variable to an Android ABI in sysconfig.get_platform(), because when the Android testbed is being cross-compiled, it stores the contents of the first substring of _PYTHON_HOST_PLATFORM before the first - symbol in the machine variable, which the dictionary does not currently handle.

@bedevere-appbedevere-appBot mentioned this pull request Mar 28, 2026
Closed
@freakboy3742

freakboy3742 commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

I'll wait until @mhsmith weighs in to confirm I haven't missed anything, but I think this all makes sense, and shouldn't impact the 64-bit builds.

mhsmith
mhsmith reviewed Apr 2, 2026
View reviewed changes
Comment threadMisc/NEWS.d/next/Build/2026-03-28-02-48-51.gh-issue-146541.k-zlM6.rst Outdated
Comment threadAndroid/android.py Outdated
Comment threadAndroid/testbed/app/build.gradle.kts
@mhsmith

mhsmith commented Apr 2, 2026

Copy link
Copy Markdown
Member

I think it would be OK to backport this to 3.13 and 3.14 to avoid future merge conflicts, as it only affects Android-specific build and test code and doesn't add any new features to Python itself.

@mhsmithmhsmith added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 2, 2026
@robertkirkman
robertkirkman marked this pull request as draft April 2, 2026 17:36
@robertkirkman
robertkirkmanforce-pushed the 32-bit-android-testbed branch 2 times, most recently from 0208457 to 6c53216CompareApril 2, 2026 22:44
@robertkirkman
pythongh-146541: Allow building the Android testbed for 32-bit targets
80da503
This allows building the Android testbed for 32-bit targets using the prebuilt 32-bit dependencies that are already available here: https://github.com/beeware/cpython-android-source-deps/releases , adding the target triplets to match them, `arm-linux-androideabi` and `i686-linux-android`.
This also adds the `arm` key to the dictionary used to convert the `machine` variable to an Android ABI in `sysconfig.get_platform()`, because when the Android testbed is being cross-compiled, it stores the contents of the first substring of `_PYTHON_HOST_PLATFORM` before the first `-` symbol in the `machine` variable, which the dictionary does not currently handle.
@robertkirkman
robertkirkmanforce-pushed the 32-bit-android-testbed branch from 6c53216 to 6eecb18CompareApril 2, 2026 22:50
@robertkirkman
robertkirkmanforce-pushed the 32-bit-android-testbed branch from 6eecb18 to b2d3a75CompareApril 2, 2026 22:53
@robertkirkman
robertkirkman marked this pull request as ready for review April 2, 2026 22:54
mhsmith
mhsmith approved these changes Apr 3, 2026
View reviewed changes

@mhsmithmhsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all looks good to me. In future, please don't force push a PR which has already been reviewed, as it makes the history difficult to understand.

@mhsmith

mhsmith commented Apr 3, 2026

Copy link
Copy Markdown
Member

!buildbot aarch64 android

@bedevere-bot

bedevere-bot commented Apr 3, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit c92b23e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146542%2Fmerge

The command will test the builders whose names match following regular expression: aarch64 android

The builders matched are:

  • aarch64 Android PR

@mhsmith

mhsmith commented Apr 3, 2026

Copy link
Copy Markdown
Member

@freakboy3742: Ready to merge.

freakboy3742
freakboy3742 approved these changes Apr 4, 2026
View reviewed changes

@freakboy3742freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robertkirkman for the PR, and @mhsmith for the review.

@freakboy3742
freakboy3742 merged commit 848bbe9 into python:mainApr 4, 2026
60 checks passed
@miss-islington-app

miss-islington-appBot commented Apr 4, 2026

Copy link
Copy Markdown

Thanks @robertkirkman for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Apr 4, 2026

Copy link
Copy Markdown

Sorry, @robertkirkman and @freakboy3742, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 848bbe9ff21ae0a3ee412cc25843835ace4f75df 3.14

@miss-islington-app

miss-islington-appBot commented Apr 4, 2026

Copy link
Copy Markdown

Sorry, @robertkirkman and @freakboy3742, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 848bbe9ff21ae0a3ee412cc25843835ace4f75df 3.13

freakboy3742 pushed a commit to freakboy3742/cpython that referenced this pull request Apr 4, 2026
@robertkirkman@mhsmith@freakboy3742
[3.14]pythongh-146541: Allow building the Android testbed for 32-bit…
3222a08
… targets (pythonGH-146542)
Allows building the Android testbed for 32-bit targets, adding the target triplets
`arm-linux-androideabi` and `i686-linux-android`.
(cherry picked from commit 848bbe9)
Co-authored-by: Robert Kirkman <31490854+robertkirkman@users.noreply.github.com>
Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app

bedevere-appBot commented Apr 4, 2026

Copy link
Copy Markdown

GH-148064 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Apr 4, 2026
@freakboy3742

freakboy3742 commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

I agree a 3.14 backport is warranted, but the 3.13 backport turns out to be non-trivial due to a conflict in sysconfig. It's not a complex change, but it definitely puts it outside the territory of a non-invasive build system change.

@FFY00

FFY00 commented Apr 4, 2026

Copy link
Copy Markdown
Member

FWIW, if you, or anyone else, has time to get the backport to a point where you are comfortable with the patch, it's okay by me. I have no strong feelings and trust your judgement. It's your call 👍

freakboy3742 added a commit that referenced this pull request Apr 4, 2026
@freakboy3742@robertkirkman@mhsmith
[3.14]gh-146541: Allow building the Android testbed for 32-bit targe…
ab3d37f
…ts (GH-146542) (#148064)
Allows building the Android testbed for 32-bit targets, adding the target triplets
`arm-linux-androideabi` and `i686-linux-android`.
(cherry picked from commit 848bbe9)
Co-authored-by: Robert Kirkman <31490854+robertkirkman@users.noreply.github.com>
Co-authored-by: Malcolm Smith <smith@chaquo.com>
@mhsmith

mhsmith commented Apr 4, 2026

Copy link
Copy Markdown
Member

It's mostly just an indentation change, similar to what happened with #145617. I'll create the backport.

mhsmith added a commit to mhsmith/cpython that referenced this pull request Apr 4, 2026
@robertkirkman@mhsmith
[3.13]pythongh-146541: Allow building the Android testbed for 32-bit…
faf8976
… targets (pythonGH-146542)
Allows building the Android testbed for 32-bit targets, adding the target triplets
`arm-linux-androideabi` and `i686-linux-android`.
(cherry picked from commit 848bbe9)
Co-authored-by: Robert Kirkman <31490854+robertkirkman@users.noreply.github.com>
Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app

bedevere-appBot commented Apr 4, 2026

Copy link
Copy Markdown

GH-148107 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 4, 2026
@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
freakboy3742 pushed a commit that referenced this pull request Apr 5, 2026
@mhsmith@robertkirkman
[3.13]gh-146541: Allow building the Android testbed for 32-bit targe…
3ea97a2
…ts (GH-146542) (#148107)
Allows building the Android testbed for 32-bit targets, adding the target triplets
`arm-linux-androideabi` and `i686-linux-android`.
(cherry picked from commit 848bbe9)
Co-authored-by: Robert Kirkman <31490854+robertkirkman@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@robertkirkman@mhsmith@ljfp
pythongh-146541: Allow building the Android testbed for 32-bit targets (
96f960a
python#146542)
Allows building the Android testbed for 32-bit targets, adding the target triplets
`arm-linux-androideabi` and `i686-linux-android`.
Co-authored-by: Malcolm Smith <smith@chaquo.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes
@mhsmithmhsmithmhsmith approved these changes
@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees

@freakboy3742freakboy3742

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android testbed fails to build for 32-bit targets

5 participants

@robertkirkman@freakboy3742@mhsmith@bedevere-bot@FFY00