Skip to content

gh-142518: add thread safety docs for set C-APIs - #146562

Merged
kumaraditya303 merged 9 commits into
python:mainfrom
kumaraditya303:set-capi
Apr 10, 2026
Merged

gh-142518: add thread safety docs for set C-APIs#146562
kumaraditya303 merged 9 commits into
python:mainfrom
kumaraditya303:set-capi

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Mar 28, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Mar 28, 2026
Closed
vstinner
vstinner reviewed Mar 31, 2026
View reviewed changes
Comment threadDoc/c-api/set.rst Outdated
Comment threadDoc/data/threadsafety.dat
Comment threadDoc/data/threadsafety.dat Outdated
Comment threadDoc/data/threadsafety.dat Outdated
@kumaraditya303kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Apr 2, 2026
vstinner
vstinner approved these changes Apr 7, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadDoc/data/threadsafety.dat
kumaraditya303and others added 2 commits April 9, 2026 20:51
@kumaraditya303@vstinner
Update Doc/data/threadsafety.dat
cce95cc
Co-authored-by: Victor Stinner <vstinner@python.org>
@kumaraditya303
align set docs with dict
1d5ab85
vstinner
vstinner reviewed Apr 10, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadDoc/data/threadsafety.dat
@@ -125,6 +125,29 @@ PyByteArray_GET_SIZE:atomic:
PyByteArray_AsString:compatible:
PyByteArray_AS_STRING:compatible:

@vstinnervstinnerApr 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add PySet_Check(), PyFrozenSet_Check(), PyAnySet_Check(), PySet_CheckExact(), PyAnySet_CheckExact() and PyFrozenSet_CheckExact() functions, they are atomic.

@kumaraditya303kumaraditya303Apr 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking of covering this and other type checks in next PR, so skipping this for now

Comment threadDoc/data/threadsafety.dat Outdated
@kumaraditya303@vstinner
Update Doc/data/threadsafety.dat
14101e5
Co-authored-by: Victor Stinner <vstinner@python.org>
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) April 10, 2026 19:27
@kumaraditya303
kumaraditya303 merged commit dd88e77 into python:mainApr 10, 2026
30 checks passed
@miss-islington-app

miss-islington-appBot commented Apr 10, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2026
@kumaraditya303@vstinner@miss-islington
pythongh-142518: add thread safety docs for set C-APIs (pythonGH-146562)
2839ee1
(cherry picked from commit dd88e77)
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented Apr 10, 2026

Copy link
Copy Markdown

GH-148362 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Apr 10, 2026
@kumaraditya303
kumaraditya303 deleted the set-capi branch April 10, 2026 19:40
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Apr 11, 2026
@kumaraditya303@vstinner
pythongh-142518: add thread safety docs for set C-APIs (python#146562)
c735c36
Co-authored-by: Victor Stinner <vstinner@python.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@kumaraditya303@vstinner@ljfp
pythongh-142518: add thread safety docs for set C-APIs (python#146562)
0cbec12
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity is a code owner

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumaraditya303@vstinner